bugGNU nano - Bugs: bug #50714, nano 2.8.0 does not compile on...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #50714: nano 2.8.0 does not compile on macOS

Submitter:  FX <fxcoudert>
Submitted:  Tue 04 Apr 2017 09:52:30 AM UTC
   
 
Severity:  3 - Normal Status:  Fixed
Assigned to:  vapier Open/Closed:  Closed

Jump to the original submission

Fri 14 Apr 2017 08:54:54 AM UTC, comment #8: 

Fix was released in 2.8.1.  Thanks for reporting.

Benno Schulenberg <bens>
Group administrator
Wed 05 Apr 2017 06:38:24 PM UTC, comment #7: 

Topher, to avoid the "invalid character class" thing, you will also need the patch from bug #50705.  Sorry for the hassle.

But it's good to see that so many Mac people use nano.  :)

Benno Schulenberg <bens>
Group administrator
Wed 05 Apr 2017 06:01:31 PM UTC, comment #6: 

With patch, syntax highlighting scripts result in "Bad regex <expression> Invalid character class name" for all lines.

Topher Kessler <tkessler>
Wed 05 Apr 2017 10:19:04 AM UTC, comment #5: 

Patch works. I have adapted it to apply directly to configure in https://github.com/Homebrew/formula-patches/commit/45f1329d2e7d515a20d286a3c81eaffcc898aae3

ilovezfs <ilovezfs>
Tue 04 Apr 2017 07:39:30 PM UTC, comment #4: 

Patch has been pushed to git, cc91ee60.

Benno Schulenberg <bens>
Group administrator
Tue 04 Apr 2017 06:07:12 PM UTC, comment #3: 

If you can build from git, please try the attached patch.
If not, 2.8.1 will appear in about two weeks.

(file #40265)

Benno Schulenberg <bens>
Group administrator
Tue 04 Apr 2017 10:59:10 AM UTC, comment #2: 

Hm.  It detects that the system regex knows about REG_ENHANCED, but then somehow during compilation decides to use the gnulib regex, which doesn't know any REG_ENHANCED.

Benno Schulenberg <bens>
Group administrator
Tue 04 Apr 2017 09:53:33 AM UTC, comment #1: 

I should add that the exact same configuration works fine with nano 2.7.4.

FX <fxcoudert>
Tue 04 Apr 2017 09:52:30 AM UTC, original submission:  

nano 2.8.0 fails to compile on macOS (10.10 to 10.12) with ncurses 6.0.

The error we get is:

clang -DHAVE_CONFIG_H -I. -I..  -DLOCALEDIR=\"/usr/local/Cellar/nano/2.8.0/share/locale\" -DSYSCONFDIR=\"/usr/local/etc\" -I../lib -I../lib -D_DARWIN_C_SOURCE -I/usr/local/Cellar/ncurses/6.0_3/include -I/usr/local/Cellar/ncurses/6.0_3/include/ncursesw   -g -O2 -Wall -c -o cut.o cut.c
color.c:146:45: error: use of undeclared identifier 'REG_ENHANCED'
        regcomp(&rgx, fixbounds(item->full_regex), NANO_REG_EXTENDED);
                                                   ^
../config.h:1695:42: note: expanded from macro 'NANO_REG_EXTENDED'
#define NANO_REG_EXTENDED REG_EXTENDED | REG_ENHANCED
                                         ^


Configure options were: ./configure --disable-debug --disable-dependency-tracking --prefix=/usr/local/Cellar/nano/2.8.0 --sysconfdir=/usr/local/etc --enable-color --enable-extra --enable-multibuffer --enable-nanorc --enable-utf8

Output of configure includes the following relevant lines:

checking for NCURSESW... yes
Using ncursesw as the curses library
checking for use_default_colors in -lncursesw... yes
checking for set_escdelay in -lncursesw... yes
checking for key_defined in -lncursesw... yes
checking for enhanced regular expression flag... REG_EXTENDED | REG_ENHANCED
checking for GNU-style word boundary regex support... no


Full output from configure and make is here: https://gist.github.com/fxcoudert/484808df4478f4d08afddd1d8ae948b0

FX <fxcoudert>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by tkessler (Posted a comment)
  • -email is unavailable- added by ilovezfs (Posted a comment)
  • -email is unavailable- added by bens (Posted a comment)
  • -email is unavailable- added by fxcoudert (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-04-14 bens StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2017-04-04 bens Assigned toNone vapier
    2017-04-04 bens StatusIn Progress Ready For Test
    2017-04-04 bens Attached File- Added 0001-configure-ignore-the-REG_ENHANCED-test-when-we-use-g.patch, #40265
        StatusNone In Progress
    2017-04-04 bens Summarynano 2.8.0 does not compile on macOS with ncurses 6.0 nano 2.8.0 does not compile on macOS

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code