bugGNU Screen - Bugs: bug #26401, failed write ACL causes all...

 
 

bug #26401: failed write ACL causes all attached displays to ring bell

Submitter:  Kees Cook <keescook>
Submitted:  Wed 29 Apr 2009 06:40:39 PM UTC
   
 
Category:  User Interface Severity:  3 - Normal
Priority:  * 5 - Normal Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Release:  4.0.3
Fixed Release:  4.1.0 Planned Release:  None
Work Required:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 20 Dec 2009 02:03:06 AM UTC, comment #1: 

Thanks! Committed and pushed (84b8ef5de3aa94d6b49e81fe4562694fb12c5d0a).

Sadrul Habib Chowdhury <sadrul>
Group administrator
Wed 29 Apr 2009 06:40:39 PM UTC, original submission:  

If several people are attached to a multi-user screen session and the are in read-only mode, each time they press a key, all attached screens will ring the bell.  The code causing this is in window.c:

      /* XXX FIXME only display !*/
      WBell(fore, visual_bell);

I would like to propose using Msg() instead, to mimic the behavior seen for disallowed screen commands seen in process.c:

      Msg(0, "write: permission denied (user %s)", D_user->u_name);

Patch attached.

Kees Cook <keescook>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #18055:  59-no-beep-on-write-acl.dpatch added by keescook (812B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by sadrul (Posted a comment)
  • -email is unavailable- added by keescook (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-12-20 sadrul StatusNone Fixed
        Open/ClosedOpen Closed
        Fixed ReleaseNone 4.1.0
    2009-04-29 keescook Attached File- Added 59-no-beep-on-write-acl.dpatch, #18055

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code