bugGNU Wget - Bugs: bug #20482, .1, .2 suffixes before extensions.

 
 

bug #20482: .1, .2 suffixes before extensions.

Submitter:  Micah Cowan <micahcowan>
Submitted:  Sat 14 Jul 2007 07:50:49 PM UTC
   
 
Category:  Program Logic Severity:  3 - Normal
Priority:  9 - Immediate Status:  Wont Fix
Privacy:  Public Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  None Operating System:  None
Reproducibility:  None Fixed Release:  None
Planned Release:  1.12 Regression:  None
Work Required:  0 - Hours Patch Included:  Yes
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 07 Dec 2007 11:26:26 PM UTC, comment #5: 

The overwhelming consensus on the ML seems to be that this is a bad idea. So, not gonna happen.

http://thread.gmane.org/gmane.comp.web.wget.general/7353

Micah Cowan <micahcowan>
Sun 04 Nov 2007 07:03:33 PM UTC, comment #4: 

May want to use ".1.html" rather than "-1.html".

strrchr() should be preferred to the for loop.

The alloca'd buffer needs a little better checking.

The link_expect_html bit may be inappropriate, and in any event doesn't belong with this patch.

Micah Cowan <micahcowan>
Sun 04 Nov 2007 12:29:32 AM UTC, comment #3: 

Christian Roche sent in a revised patch, and information on how to reproduce the accept/reject problem he was having. I've attached these.

(file #14288, file #14289, file #14290)

Micah Cowan <micahcowan>
Mon 15 Oct 2007 05:53:11 AM UTC, comment #2: 

The patch may need some adjustment. The patch accidentally includes some documentation related to a different patch that was sent at the same time.

The actual change to utils could be optimized for space: it reserves enough space for the full size of the file name, when the space required for prefix and suffix should actually be fairly easily determined in advance, and actually wouldn't even need separate buffers.

Micah Cowan <micahcowan>
Wed 01 Aug 2007 12:14:54 AM UTC, comment #1: 

See also bug 20414, which addresses the broader issue of matching local filenames instead of remote filenames, against the accept/reject rules.

This change still seems appropriate, though, since it preserves the extensions for file-type identification purposes.

Micah Cowan <micahcowan>
Sat 14 Jul 2007 07:50:49 PM UTC, original submission:  

From http://article.gmane.org/gmane.comp.web.wget.patches/2140 , where the ChangeLog entries for this and another patch may be found.

patch-utils changes the file renaming mechanism when
the -nc option is in effect.  Instead of trying to
rename  a file to file.1, file.2 etc, it tries
prefix-1.suffix, prefix-2.suffix etc, thus preserving
the filename extension if any.  This is necessary to
avoid a bug otherwise when the -A option is used:
renamed files are rejected because they don't match
the required suffix, although they should really be
kept.

Micah Cowan <micahcowan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #14288:  log.txt added by micahcowan (3KiB - text/plain)
file #14289:  new-patch-utils.txt added by micahcowan (6KiB - text/plain)
file #14290:  new-patch-http.txt added by micahcowan (9KiB - text/plain)
file #13342:  patch-utils.txt added by micahcowan (5KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by micahcowan (Submitted the item)
  •  

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-12-07 micahcowan StatusConfirmed Wont Fix
        Open/ClosedOpen Closed
    2007-11-04 micahcowan Attached File- Added log.txt, #14288
        Attached File- Added new-patch-utils.txt, #14289
        Attached File- Added new-patch-http.txt, #14290
        Priority4 9 - Immediate
    2007-08-01 micahcowan Priority5 - Normal 4
    2007-07-20 micahcowan Work RequiredNone 0 - Hours
    2007-07-14 micahcowan Attached File- Added patch-utils.txt, #13342

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code