bugGNU Octave - Bugs: bug #65725, Editor Window problems in...

 
 

bug #65725: Editor Window problems in candidate release GNU Octave, version 9.1.90

Submitter:  Ray Cross <ray_obr>
Submitted:  Sat 11 May 2024 03:57:47 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 9.1.0 Release: 
Operating System:  * Any Fixed Release:  9.2.0
Planned Release:  9.2.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 16 May 2024 03:20:11 PM UTC, comment #20: 

i've never customized the merge tool options, so i assume it's a default option in the windows hg implementation (using the tools bundling with TortoiseHg).  will look at separately. thanks for cleaning this up.

Nicholas Jankowski <nrjank>
Group Member
Thu 16 May 2024 02:59:59 PM UTC, comment #19: 

I guess that message came from your merge tool (docdiff?).
I don't know why Mercurial chose that tool for you. Maybe, check your configuration?

Markus Mützel <mmuetzel>
Group administrator
Thu 16 May 2024 02:52:53 PM UTC, comment #18: 

is a misleading "Unsupported file type XYZ" error message common when it just runs into whitespace differences? will at least know what to look for next time.

Nicholas Jankowski <nrjank>
Group Member
Thu 16 May 2024 08:05:47 AM UTC, comment #17: 

It looks like there are some whitespace changes between the stable and default branch in that file. That meant that the merge didn't succeed automatically.
Pushed a merge commit after resolving the whitespace conflicts manually:
https://hg.savannah.gnu.org/hgweb/octave/rev/a56b2283959a

Markus Mützel <mmuetzel>
Group administrator
Wed 15 May 2024 05:54:13 PM UTC, comment #16: 

@nrjank:
Yeah I had issues with file-editor.cc as well, there's a function definition that has changed at L.1617 (IIRC), apparently silently. I searched file-editor.cc's file log but couldn't find when it has changed, let alone why. Anyway I manually edited it and then the build went fine.

Unfortunately it's on my other PC so I can't reproduce now.

Philip Nienhuis <philipnienhuis>
Group Member
Wed 15 May 2024 04:48:37 PM UTC, comment #15: 

just pulled down the latest nightly build for windows including this patch and it does fix it.  the editor now creates a new full window when dragged out of the main gui window.

was going to push the patch to default but getting the following:


$ hg merge stable
merging libgui\src\m-editor\file-editor.cc
running merge tool docdiff for file libgui\src\m-editor\file-editor.cc
Unsupported file type .cc
merging libgui\src\m-editor\file-editor.cc failed!
0 files updated, 0 files merged, 0 files removed, 1 files unresolved
use 'hg resolve' to retry unresolved file merges or 'hg merge --abort' to abandon


i've edited .cc files before, so not sure what the issue is here.

Nicholas Jankowski <nrjank>
Group Member
Wed 15 May 2024 04:44:56 PM UTC, comment #14: 

Thanks for testing everyone. Closing as fixed.

Torsten Lilge <ttl>
Group Member
Wed 15 May 2024 04:27:26 PM UTC, comment #13: 

It was pushed to stable, but stable wasn't merged to release or default afterwards.

On my Windows builds I usually merge all branches to the BI branches before building.

Philip Nienhuis <philipnienhuis>
Group Member
Wed 15 May 2024 03:57:16 PM UTC, comment #12: 


comment #11:

> Works fine now on Windows w 10.0.0 BI as well


I do not think the patch was applied to dev.
I definitely still see the problem with 3fe954c2fd25 @

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Wed 15 May 2024 01:52:51 PM UTC, comment #11: 

Works fine now on Windows w 10.0.0 BI as well

Philip Nienhuis <philipnienhuis>
Group Member
Wed 15 May 2024 05:02:56 AM UTC, comment #10: 

Works for me on Linux and Windows.

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Tue 14 May 2024 08:44:05 PM UTC, comment #9: 

hg id: 3216c01fd6a7
has fixed it for me on Ubuntu 23.10

Doug Stewart <dastew>
Tue 14 May 2024 08:10:57 PM UTC, comment #8: 

The cause was just a missing call to the base class slot from the derived class slot. This is fixed with cset https://hg.savannah.gnu.org/hgweb/octave/rev/3216c01fd6a7

@dasergatskov or @nrjank: It would be nice if you could test the new cset on windows.

Torsten Lilge <ttl>
Group Member
Tue 14 May 2024 04:56:18 AM UTC, comment #7: 

Thanks for testing. I can now also reproduce it when dragging the editor out of the main window. In this case, the editor does not really get into the "floating" state. It does not get its own title bar from the window manager and the dock/undock button does not change to "dock". Moreover when clicking this button it goes into real floating mode with its own title bar.

Torsten Lilge <ttl>
Group Member
Mon 13 May 2024 07:26:57 PM UTC, comment #6: 

Also, when I detach editor with a mouse the editor windows in some mode when it would "snap" pack into main gui if I move it over it.

I think this is why it stays on top -- it is half way in "windows re-arrangement" mode rather than in "Windows de-tached" mode.

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Mon 13 May 2024 07:17:51 PM UTC, comment #5: 

Also, to reproduce "bad" behaviour you need to detach the editor windows by "pulling" it out with a mouse. If you use "Dock"/"Un-dock" control it behaves as expected.

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Mon 13 May 2024 07:10:17 PM UTC, comment #4: 

Also, if I exit octave while editor is detached, then on restart it behaves as expected (i.e. main gui windows goes on foreground).

If I click "reset default" and detach editor again, it switches back to "bad" behavior.

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Mon 13 May 2024 07:01:38 PM UTC, comment #3: 

I can reproduce the problem with the editor windows staying in foreground in both Windows and Linux.

Essentially de-tached editor from gui.
Switch to command Window and type something there.
The editor windows will stay in-front.

This is with 9.1.91 (2024-05-12)

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Sun 12 May 2024 11:06:39 AM UTC, comment #2: 

Can you describe an exact set of steps another windows user could follow to try to reproduce the issue?

Nicholas Jankowski <nrjank>
Group Member
Sun 12 May 2024 10:50:14 AM UTC, comment #1: 

Thanks for the report. I am on Debian with Gnome and can not reproduce the issues that you are describing. In particular,

  • the main window move on top of the floating editor when getting focus
  • the floating editor can be minimized from full screen by the minimize button in the title bar or the related shortcut
  • the floating editor can be dragged away from full screen by the mouse.


What do you mean by "the editor window doesn't always resize correctly". Resize with respect to what and when?

Torsten Lilge <ttl>
Group Member
Sat 11 May 2024 03:57:47 PM UTC, original submission:  

While using candidate release GNU Octave version 9.1.90 to investigate whether another bug (unrelated? #65623) had been corrected, discovered that editor window when detached as a separate window:

  • stays in foreground over top of the other main GUI window even when the main GUI window has been selected
  • the editor window doesn't always resize correctly
  • when editor window is full screen, does not allow pulling away with cursor to minimize -- minimize doesn't always seem to work either.
Ray Cross <ray_obr>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by dastew (Posted a comment)
  • -email is unavailable- added by dasergatskov (Posted a comment)
  • -email is unavailable- added by nrjank (Posted a comment)
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by ray_obr (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 13 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-05-16 mmuetzel Fixed ReleaseNone 9.2.0
        Planned ReleaseNone 9.2.0
    2024-05-15 nrjank StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2024-05-15 nrjank StatusFixed Ready For Test
        Open/ClosedClosed Open
    2024-05-15 ttl StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2024-05-14 ttl StatusNeed Info Ready For Test
        Operating SystemMicrosoft Windows Any
    2024-05-12 nrjank Item GroupNone Other
        StatusNone Need Info
        Releasedev 9.1.0

    Back to the top

    Powered by Savane 3.15-e6e5.
    Corresponding source code