bugGNU Octave - Bugs: bug #51766, [octave forge] (interval)...

 
 

bug #51766: [octave forge] (interval) pdftocairo build rule is not safe for parallel make

Submitter:  Mike Miller <mtmiller>
Submitted:  Wed 16 Aug 2017 05:42:42 PM UTC
   
 
Category:  Octave Package Severity:  2 - Minor
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 16 Aug 2017 10:06:06 PM UTC, comment #2: 

Works for me now, thank you.

Mike Miller <mtmiller>
Group Member
Wed 16 Aug 2017 10:00:41 PM UTC, comment #1: 

Fixed it.  After looking up how the automatic variable $* can be used,  I could get rid of the temporary file entirely.

https://sourceforge.net/p/octave/interval/ci/caa1427ae3b7c41d09233bf5fe78201348e8a3a6/

Oliver Heimlich <oheim>
Wed 16 Aug 2017 05:42:42 PM UTC, original submission:  

When running "make -j8 dist", the build rule that calls pdftocairo is not thread-safe since it uses the same intermediate file name for each command. This file needs to be either randomized or based on the input argument.

The following change fixes this for me


diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -192,8 +192,8 @@ endif
 $(GENERATED_IMAGE_DIR)/%.svg.png: $(GENERATED_IMAGE_DIR)/%.svg.pdf
        @# The output of pdftocairo has a much better quality
        @# compared to the output from inkscape --export-png.
-       @pdftocairo -png -singlefile -transp -r 120 "$<" "$(BUILD_DIR)/cairo.tmp"
-       @mv "$(BUILD_DIR)/cairo.tmp.png" "$@"
+       @pdftocairo -png -singlefile -transp -r 120 "$<" "$(BUILD_DIR)/$*.tmp"
+       @mv "$(BUILD_DIR)/$*.tmp.png" "$@"
 $(GENERATED_IMAGE_DIR)/%.svg.eps $(GENERATED_IMAGE_DIR)/%.svg.pdf: doc/image/%.svg | $(GENERATED_IMAGE_DIR)
        @echo "Compiling $< ..."
        @inkscape --without-gui \


Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by oheim (Posted a comment)
  • -email is unavailable- added by oheim (pkg maintainer)
  • -email is unavailable- added by mtmiller (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-08-16 mtmiller StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2017-08-16 oheim Carbon-Copy- Added oheim

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code