bugGNU Octave - Bugs: bug #46309, [octave forge] (odepkg) does not...

 
 

bug #46309: [octave forge] (odepkg) does not build with 64bit enabled Octave

Submitter:  Martin K <grisu86>
Submitted:  Wed 28 Oct 2015 12:39:45 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Works For Me Assigned to:  cdf
Originator Name:  Open/Closed:  * Closed
Release:  * 5.1.0 Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 04 Dec 2019 08:28:59 AM UTC, comment #5: 

The "odepkg" from SourceForge is discontinued and Octave 4.2 is outdated by now.

The method described in comment #1 and https://wiki.octave.org/Odepkg to install the "odepkg" BitBucket version works with the current stable release Octave 5.1.0 (and 4.4.1) and 64 Bit indices enabled.

Closing report.

Kai Torben Ohlhus <siko1056>
Group Member
Thu 19 Oct 2017 10:52:10 AM UTC, comment #4: 

Hi Carlo-- Thank you for adding the caveats on the odepkg 0.8.5.

There is no need for a patch relative to the current development repository, because it already works with Octave 4.2.1

Nir Krakauer <nir_krakauer>
Thu 19 Oct 2017 08:16:09 AM UTC, comment #3: 

Hi,

odepkg 0.8.5 should NOT be installed
in Octave 4.2 as it shadows ode solvers and utilities
that are now built into core.

Unfortunately it seems pkg does not have a "maximum
compatibility version" feature in order to prevent this.

It seems many of the changes you made are already in the
development repository.

Can you please rework this as a changeset relative
to the current development repository of odepkg?

If you want this to work with Octave 4.2.1 you should
compare to the "default" branch.

  https://bitbucket.org/odepkg/odepkg/src

Ideally, a pull request on bitbucket would be even better.

Thanks,
c.


Carlo de Falco <cdf>
Group Member
Wed 18 Oct 2017 05:32:44 PM UTC, comment #2: 

I made a patch that enabled me to install the odepkg 0.8.5 release with Octave 4.2.1 on Mac (Homebrew). It includes Martin's fixes and also replaces GCC_ATTR_UNUSED with OCTAVE_UNUSED and removes returns with expression for void functions. I'm attaching it here in case someone finds it useful. The current development version of odepkg works fine for me without patching.

(file #42190)

Nir Krakauer <nir_krakauer>
Mon 14 Aug 2017 01:03:17 PM UTC, comment #1: 

A fix for this has been applied in the
development repository for odepkg,
I used a different patch provided by jwe
elsewhere instead of that posted here though.
This is only expected to work with Octave
4.3.0+.

Testing is welcome, to test the latest
version please try


[fname, success] = urlwrite ("https://bitbucket.org/odepkg/odepkg/get/octave43.tar.gz", [P_tmpdir "odepkg.tar.gz"]);
assert (success)
pkg ("install", fname)


c.

Carlo de Falco <cdf>
Group Member
Wed 28 Oct 2015 12:39:45 PM UTC, original submission:  

I am using Octave 4.0.0 with 64bit integer support. Compiled with gcc 4.8.5. When I try to install odepkg 0.8.5 from Octave-Forge I got the error below. The error exists in 4 files an can be fixed by a typecast. Furthermore, the Makefile does not read the F77_INTEGER8_FLAG out of the mkoctfile data. 

I attached a patch, which solved the problem on my system.



g++ -c  -fPIC -I/scratch/koehlerm/local_install/conda-2.7/include/octave-4.0.0/octave/.. -I/scratch/koehlerm/local_install/conda-2.7/include/octave-4.0.0/octave -I/scratch/koehlerm/local_install/conda-2.7/include -pthread -fopenmp -I/scratch/koehlerm/local_install/conda-2.7/includeCPPFLAGS=-I/scratch/koehlerm/local_install/conda-2.7/include    odepkg_octsolver_radau.cc -o odepkg_octsolver_radau.o
In file included from odepkg_octsolver_radau.cc:35:0:
odepkg_octsolver_radau.cc: In function ‘octave_value_list Fode2r(const octave_value_list&, int)’:
odepkg_octsolver_radau.cc:612:24: error: invalid conversion from ‘int (*)(const octave_idx_type&, double*, const octave_idx_type*, const double*, const octave_idx_type*) {aka int (*)(const long int&, double*, const long int*, const double*, const long int*)}’ to ‘odepkg_radau_masstype {aka long int (*)(const long int&, double*, const long int*, const double*, const long int*)}’ [-fpermissive]
              IPAR, IDID));
                        ^
/scratch/koehlerm/local_install/conda-2.7/include/octave-4.0.0/octave/f77-fcn.h:70:27: note: in definition of macro ‘F77_XFCN’
           F77_FUNC (f, F) args; \
                           ^
In file included from /scratch/koehlerm/local_install/conda-2.7/include/octave-4.0.0/octave/oct.h:31:0,
                 from odepkg_octsolver_radau.cc:34:
odepkg_octsolver_radau.cc:65:23: error:   initializing argument 14 of ‘int radau_(const octave_idx_type&, odepkg_radau_usrtype, const double&, const double*, const double&, const double&, const double*, const double*, const octave_idx_type&, odepkg_radau_jactype, const octave_idx_type&, const octave_idx_type&, const octave_idx_type&, odepkg_radau_masstype, const octave_idx_type&, const octave_idx_type&, const octave_idx_type&, odepkg_radau_soltype, const octave_idx_type&, const double*, const octave_idx_type&, const octave_idx_type*, const octave_idx_type&, const double*, const octave_idx_type*, const octave_idx_type&)’ [-fpermissive]
   F77_RET_T F77_FUNC (radau, RADAU)
                       ^
/scratch/koehlerm/local_install/conda-2.7/include/octave-4.0.0/octave/config.h:92:29: note: in definition of macro ‘F77_FUNC’
 #define F77_FUNC(name,NAME) name ## _
                             ^
make: *** [odepkg_octsolver_radau.o] Error 1
make: Leaving directory `/tmp/oct-rL8GGn/odepkg-0.8.5/src'


Martin K <grisu86>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #42190:  odepkg085.patch added by nir_krakauer (56KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by siko1056 (Posted a comment)
  • -email is unavailable- added by nir_krakauer (Updated the item)
  • -email is unavailable- added by cdf (Posted a comment)
  • -email is unavailable- added by cdf
  • -email is unavailable- added by jwe (Updated the item)
  • -email is unavailable- added by grisu86 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 13 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-12-04 siko1056 StatusPatch Submitted Works For Me
        Open/ClosedOpen Closed
        Releasedev 5.1.0
    2018-07-02 jwe Summary[octave-forge] (odepkg) does not build with 64bit enabled Octave [octave forge] (odepkg) does not build with 64bit enabled Octave
    2017-10-18 nir_krakauer Attached File- Added odepkg085.patch, #42190
    2017-08-14 cdf Assigned toNone cdf
        Release4.0.0 dev
        Summary[octave-forge] (odepkg) 0.8.5 does not build with 64bit enabled Octave [octave-forge] (odepkg) does not build with 64bit enabled Octave
        Carbon-Copy- Added -email is unavailable-
        Carbon-Copy- Added -email is unavailable-
    2017-08-11 jwe Summaryodepkg 0.8.5 does not build with 64bit enabled Octave [octave-forge] (odepkg) 0.8.5 does not build with 64bit enabled Octave
    2015-10-31 philipnienhuis StatusNone Patch Submitted
    2015-10-28 grisu86 Attached File- Added fix-odepkg-0.8.5-int8.patch, #35321

    Back to the top

    Powered by Savane 3.13-cf05.
    Corresponding source code