bugGNUstep - Bugs: bug #15289, gnustep-make 1.11.2 -> openapp...

 
 

bug #15289: gnustep-make 1.11.2 -> openapp looks for bogus paths when omitting ".app", ".debug", etc.

Submitted by:  Nikolaus Waxweiler <madleser>
Submitted on:  Sun 25 Dec 2005 07:34:55 PM UTC  
 
Category:  Makefiles Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  Adam Fedor <fedor>
Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 01 Jan 2006 03:51:46 PM UTC, comment #3: 

I reverted that patch as it just re-introduced an earlier bug (use of a colon as IFS breaks path names under windows as it separates drives from the rest of the path).

I've rewritten the code for guessing the application suffix so that it doesn't use a list/IFS.

The problem with launch in ProjectCenter is a bug in ProjectCenter ... it was not specifying what to launch,just hoping that openapp owuld pick the correct one.  This has never worked properly for cases where a user has their path set up in an unusual way.  The fix is to get ProjectCenter to specify the full path of the application it wishes to launch.

Richard Frith-Macdonald <CaS>
Project Member
Sat 31 Dec 2005 05:05:12 AM UTC, comment #2: 

Applied the patch and follow up. Thanks.

Adam Fedor <fedor>
Project AdministratorIn charge of this item.
Tue 27 Dec 2005 07:41:28 PM UTC, comment #1: 

Another thing: it doesn't look in the current working directory when given only an application name, no path-seperators. This breaks the "Launch" button in ProjectCenter, which executes "openapp AppName" in the application's source-directory.

Fix: Change the line 'for dir in "$GNUSTEP_USER_ROOT" "$GNUSTEP_LOCAL_ROOT" "$GNUSTEP_NETWORK_ROOT" "$GNUSTEP_SYSTEM_ROOT"; do' to something including '"."'.

Nikolaus Waxweiler <madleser>
Sun 25 Dec 2005 07:34:55 PM UTC, original submission:  

Neither bash, nor zsh, nor the FreeBSD sh break up the ":"-seperated app_list in line 89 when doing "for appdir in $app_list; ...".

Fix: Set the IFS variable accordingly. This was done in 1.11.1 but removed in 1.11.2. It doesn't seem to be mentioned in the changelog though.. See the attached patch.

Nikolaus Waxweiler <madleser>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #2272:  openapp.in.patch added by madleser (258B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-12-31 fedor StatusNone => Fixed
    Assigned toNone => fedor
    Open/ClosedOpen => Closed
2005-12-25 madleser Attached File- => Added openapp.in.patch, #3213

Back to the top


Powered by Savane 3.6