bugGNUstep - Bugs: bug #12401, framework fails to build if...

 
 

bug #12401: framework fails to build if FRAMEWORK_NAME contains -

Submitted by:  matt rice <ratmice>
Submitted on:  Mon 21 Mar 2005 03:02:37 AM UTC  
 
Category:  Makefiles Severity:  3 - Normal
Item Group:  Bug Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 12 Jul 2005 02:11:43 PM UTC, comment #4: 

I fixed this on CVS ... since I was there I also allowed '+' in framework names.

Thanks

Nicola Pero <nico>
Project Member
Wed 06 Apr 2005 12:07:39 PM UTC, comment #3: 

Cool ... excellent example - Thanks! :-)

I think we might want to allow '-' in framework names ... and we can decide that '+' is forbidden instead.

Thanks

Nicola Pero <nico>
Project Member
Wed 06 Apr 2005 11:54:32 AM UTC, comment #2: 

I only noticed this while I was converting my local copy of gnustep-base and gnustep-gui to frameworks, and before I'd changed their names to Foundation and AppKit,

in general I would say no, we don't need to support the -/+ in framework names, though i'm not a big fan of 'exceptions to the rule'

could this be made a property list which gets copied into the framework?

another example where I think the current solution weird is i have a program to create a graphviz graph of a class heirarchy from a shared library, and when run on a framework one has to tell it to ignore this class..

anyhow, minor stuff, easiest just to not allow +/-

matt rice <ratmice>
Project Member
Wed 06 Apr 2005 11:34:48 AM UTC, comment #1: 

Thanks.  Do we need to support '-/+' in framework names though ?

Any real example of a framework with a '-/+' in the name which really needs to have a '-/+' in the name.

My temptation would be not to allow '-/+' in names ... maybe generate an error message ?

Thanks

Nicola Pero <nico>
Project Member
Mon 21 Mar 2005 03:02:37 AM UTC, original submission:  

because - and + are not valid in class names
and it attempts to create a class similar to NSFramework_Foo-Bar

matt rice <ratmice>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 2 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-07-12 nico Open/ClosedOpen => Closed
2005-04-06 nico Summaryframework fails to build if FRAMEWORK_NAME contains - or + => framework fails to build if FRAMEWORK_NAME contains -

Back to the top


Powered by Savane 3.6