bugGNU arch -- a revision control system - Bugs: bug #7223, add-id's detects of automatic...

 
 

bug #7223: add-id's detects of automatic changelog ids fails if the revision is not of the form 0.1

Submitted by:  Elmar Hoffmann <elho>
Submitted on:  Tue 13 Jan 2004 01:18:30 PM UTC  
Votes:  75  
 
Category: tlaSeverity: 3 - Normal
Item Group: bugStatus: None
Privacy: PublicOpen/Closed: Open
Release: tla--devo--1.2--patch-57
Fixed Release: 
Merge Request?: None
Your Archive Name: 
Your Archive Location: 
Assigned to: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 25 Jul 2006 03:30:26 PM UTC, comment #2:

The workaround I have been using ever since reporting this bug is to do the following instead of 'tla add-id ChangeLog':

ID=$(grep '^# arch-tag: ' ChangeLog | sed 's/^# arch-tag: //') && echo $ID
tla add-id --id $ID ChangeLog

Which forces tla to use the original id from the tagline that does match arch_changelog_id_re. No need to change the tagging method. (The echo $ID is only there to see what's going on :))

Elmar Hoffmann <elho>
Thu 16 Jun 2005 07:02:25 PM UTC, comment #1:

I can confirm this: I usually use two version numbers after the dot (e.g. "0.01", "0.10", "1.40", etc.), and my ChangeLog isn't updated with a commit.
Any news of a fix?

Matteo Settenvini <tchernobog>
Tue 13 Jan 2004 01:18:30 PM UTC, original submission:

Using a single digit revision the problem shows as follows, resulting in a ChangeLog that does not automatically update:
$ tla changelog >ChangeLog
$ grep arch-tag ChangeLog
# arch-tag: automatic-ChangeLog--elho@elho.net--foo/foo--main--0
$ tla add ChangeLog
$ tla inventory --ids
S ChangeLog x_Elmar_Hoffmann_<elho@elho.net>_Tue_Jan_13_11:53:12_2004_24707.0

Using a digit-dot-digit style revision it works fine:
$ tla changelog >ChangeLog
$ grep arch-tag ChangeLog
# arch-tag: automatic-ChangeLog--elho@elho.net--bar/bar--main--0.1
$ tla add ChangeLog
$ tla inventory --ids
S ChangeLog x_automatic-ChangeLog--elho@elho.net--bar/bar--main--0.1

tla obviously allows more general revisions to be created than it later checks for.
The described problem with add-id lies in the following regexp which is used in the latter one:
libarch/namespace.h:#define arch_vsn_re "[[:([0-9]+\\.[0-9]+):]]"
libarch/changelogs.c:#define arch_changelog_id_re "^([ix]_automatic-ChangeLog--)(" arch_archive_re ")/(" arch_base_re ")(--" arch_base_re ")?(--" arch_vsn_re ")$"

Elmar Hoffmann <elho>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 75 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 25 Jul 2006 03:30:26 PM UTCelhoCarbon-Copy-=>Added elho
Tue 28 Feb 2006 06:51:05 PM UTCdwmCarbon-Copy-=>Added dwm
Thu 16 Jun 2005 07:02:25 PM UTCtchernobogCarbon-Copy-=>Added tchernobog

Back to the top


Powered by Savane 3.1-cleanup1