bugGNU arch -- a revision control system - Bugs: bug #6785, DAV with http_proxy will cause...

 
 

bug #6785: DAV with http_proxy will cause spurious free().

Submitter:  None
Submitted:  Wed 26 Nov 2003 04:57:58 PM UTC
   
 
Category:  tla Severity:  3 - Normal
Item Group:  bug Status:  None
Privacy:  Public Open/Closed:  Open
Release:  1.1pre9
Fixed Release: 
Merge Request?:  yes -- diffs included
Your Archive Name: 
Your Archive Location: 
Assigned to:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 29 Nov 2003 02:24:17 PM UTC, comment #1: 

May I offer the following patch under consideration.  In addition to the
invalid free() it should fix the following problems as well:

1. trailing slash makes parsing the port number fail
2. if you leave out the optional port number, the proxy setup is silently
   skipped

AIUI, in its present form the only format that is properly recognized is:

http://host:port

After this patch, also the following should work as expected:

http://host:port/
http://host/      -- will use default HTTP port 80
http://host       -- will use default HTTP port 80

The port 80 is hardcoded; if one wants to be meticulous, one should probably
consider using getservent() instead.


Anonymous
Wed 26 Nov 2003 04:57:58 PM UTC, original submission:  

If you set http_proxy environment variable and use DAV for archive access, then tla usually dies in arch_pfs_dav_connect. The reason is that it frees a wrong pointer there.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #893:  pfs-dav-proxy.diff added by None (1018B - text/plain - An alternate fix)
file #880:  dav-diff added by None (1006B - text/plain - A fix)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2003-12-01 tko Carbon-Copy- Added tko
2003-11-29 None Attached File- Added pfs-dav-proxy.diff, #887
2003-11-26 None Attached File- Added dav-diff, #874

Back to the top

Powered by Savane 3.13-3cd0.
Corresponding source code