bugGNU roff - Bugs: bug #64986, [PATCH] add .em1 request

 
 

bug #64986: [PATCH] add .em1 request

Submitter:  Dave <barx>
Submitted:  Tue 05 Dec 2023 08:51:27 PM UTC
   
 
Category:  Core Severity:  1 - Wish
Item Group:  Feature change Status:  Duplicate
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 26 Dec 2023 08:08:12 PM UTC, comment #3: 

Resolving as duplicate of bug #64582.

G. Branden Robinson <gbranden>
Group administrator
Fri 08 Dec 2023 02:02:22 AM UTC, comment #2: 

I submitted this as an enhancement I found in the archives that sounded useful that seemed to have gotten lost.  I failed to realize it covered the same problem as #64582 or I'd have posted it as an attachment/comment there.  So this ticket can be closed as a dup, or both can remain open until there's a decision on which solution to use.

I've not run into this .em issue so I have no stake in how it's resolved.

Dave <barx>
Group Member
Thu 07 Dec 2023 10:54:27 AM UTC, comment #1: 

I'm thinking I'd rather fix this by the means described in bug #64582.  That is, just change `em` to behave as `em1` is proposed to, unless compatibility mode is enabled.  This would be a NEWS-worthy change, but I think few people apart from macro package authors ever use the `em` request.

I'm open to feedback.

G. Branden Robinson <gbranden>
Group administrator
Tue 05 Dec 2023 08:51:27 PM UTC, original submission:  

These threads (actually one thread, but the archiver split it up)

explain a limitation of the .em request and introduce a new request, .em1, that doesn't have this limitation.

The thread ended with Werner's patch and call for testing, so perhaps the patch was never committed because no one followed up.

However, the patch only adds a new request, and doesn't affect the behavior of any existing ones, so the risk of regression is low even if the new request does have bugs.  We also have a robust testing framework now to catch regressions, something lacking in 2009.

The code has changed too much since 2009 for the patch to apply as-was, so I generated a new patch that applies to the current src/roff/troff/input.cpp.  I kept Werner's constructs even in places I might have refactored things, but tweaked his names to match the code's current nomenclature (e.g. "eoi_macro1" in place of his "end_macro1", since the extant "end_macro" has been since renamed "eoi_macro").

The patch doesn't update any documentation to cover the new request.  The person likeliest to apply the patch will have his own ideas about how to best document it.  But I'm willing to tackle this instead if he'd rather delegate that.

Dave <barx>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #55408:  em1.revised.patch added by barx (2KiB - text/x-diff - Werner's .em1 patch, revised to apply to current code)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by barx (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-12-26 gbranden StatusNeed Info Duplicate
        Assigned toNone gbranden
        Open/ClosedOpen Closed
    2023-12-07 gbranden StatusNone Need Info
    2023-12-05 barx Attached File- Added em1.revised.patch, #55408

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code