bugGNU roff - Bugs: bug #64081, [mm] verify that user-configured...


bug #64081: [mm] verify that user-configured paragraph indentation is respected

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Thu 20 Apr 2023 09:42:21 PM UTC
Category:  Macro mm Severity:  3 - Normal
Item Group:  Test Status:  Confirmed
Privacy:  Public Assigned to:  None
Open/Closed:  Open Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup

Fri 21 Apr 2023 02:03:59 AM UTC, comment #1: 

I'm not sure I agree with your presentation of this.

First, it's not a matter of "robustness" but of feature coverage.

"Robustness" is, roughly speaking, resistance to weathering (environmental factors), error, damage, or breakage.

The test as I wrote it is designed to verify the correct indentation behavior of the various paragraph types, because each type differs in whether indentation is applied or not.

That the paragraph indentation amount is configurable in mm is another matter entirely.

I can foresee a separate test that checks whether the paragraph indentation as specified by the user (by modifying the `Pi` register is honored.

Also, if we should inadvertently change the O or Pi register defaults, the existing test would catch that, and with your changes it would not, since it extracts their values and accepts them whatever they may be.

Thus, I am rejecting the patch, dropping the summary tag, redrawing the scope of the ticket, and retaining it.  I don't object to the idea; the more test coverage we can get of mm compared to its current amount, the better.

G. Branden Robinson <gbranden>
Group administrator
Thu 20 Apr 2023 09:42:21 PM UTC, original submission:  

From: Bjarni Ingi Gislason <bjarniig@simnet.is>
Date: Thu, 20 Apr 2023 21:34:11 +0000
Subject: [PATCH] [mm] P-indentation-works.sh: make it more robust

Directory: contrib/mm/tests/

  Use the register 'O' and 'Pi' in the mm macro to calculate the
expected indents and use these instead of constant numbers.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@simnet.is>
 contrib/mm/tests/P-indentation-works.sh | 36 +++++++++++++++++--------
 1 file changed, 25 insertions(+), 11 deletions(-)

Patch is in the attachment.

Bjarni Ingi Gislason <bjarniig>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.


    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-04-21 gbranden Summary[mm] verify that user configured paragraph indentation is respected [mm] verify that user-configured paragraph indentation is respected
    2023-04-21 gbranden StatusNone Confirmed
        Summary[PATCH] P-indentation-works.sh: make it more robust [mm] verify that user configured paragraph indentation is respected
    2023-04-20 bjarniig Attached File- Added 0001-P-indentation-works.sh-make-it-more-robust.txt, #54645

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code