bugGNU roff - Bugs: bug #63695, [mm] omits vertical space after...

 
 

bug #63695: [mm] omits vertical space after inside address in LT letters

Submitter:  G. Branden Robinson <gbranden>
Submitted:  Mon 23 Jan 2023 10:44:04 PM UTC
   
 
Category:  Macro mm Severity:  3 - Normal
Item Group:  Incorrect behaviour Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.24.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 10 Jul 2023 08:49:15 AM UTC, comment #4: 

Fixed and regression-tested.


commit 1be1c3a2cba296c26fbea45beab4e0973f5061d6
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu May 25 12:37:45 2023 -0500

    [mm]: Fix Savannah #63695.

    * m.tmac (let@print-head): Unconditionally put one vee of space on the
      output before returning.

    Fixes <https://savannah.gnu.org/bugs/?63695>.

commit 403b3f3d34e3b37a678b41ac4a96a1ae70e13d3f
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu May 25 12:35:56 2023 -0500

    [mm]: Regression-test Savannah #63695.

    * contrib/mm/tests/LT-should-space-after-inside-address.sh: Do it.
    * contrib/mm/mm.am (mm_TESTS): Run test.

    Test fails at this commit.


G. Branden Robinson <gbranden>
Group administrator
Thu 01 Jun 2023 02:53:12 PM UTC, comment #3: 

Fixed on my branch.


commit 41580f080c5f9d4a5e1d1b64cd17877a92761d9d
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu May 25 12:37:45 2023 -0500

    [mm]: Fix Savannah #63695.

    * m.tmac (let@print-head): Unconditionally put one vee of space on the
      output before returning.

    Fixes <https://savannah.gnu.org/bugs/?63695>.

commit dfd4285e93501ca4a586641190bec9fc032e4fad
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu May 25 12:35:56 2023 -0500

    [mm]: Regression-test Savannah #63695.

    * contrib/mm/tests/LT-should-space-after-inside-address.sh: Do it.
    * contrib/mm/mm.am (mm_TESTS): Run test.

    Test fails at this commit.


G. Branden Robinson <gbranden>
Group administrator
Thu 25 May 2023 05:09:06 PM UTC, comment #2: 

This problem turns out to be a little more general.  It can be observed even if no letter options are used.


$ cat EXPERIMENTS/simple-letter.mm
.ND "17 May 2023"
.WA "Epi G. Netic" "Head of Research"
123 Main Street
Anytown, ST  10101
.WE
.IA "Rufus T. Arbogast" "Guru"
456 Elsewhere Avenue
Nirvana, PA  20406
.IE
.LT
.P
We have a research leak!
.FC
.SG
.NS
sundry careless people
.NE
$ nroff -mm EXPERIMENTS/simple-letter.mm|cat -s # groff 1.22.4

                                     123 Main Street
                                     Anytown, ST  10101
                                     17 May 2023

       Rufus T. Arbogast
       Guru
       456 Elsewhere Avenue
       Nirvana, PA  20406
       We have a research leak!

                                     Yours very truly,

                                     Epi G. Netic
                                     Head of Research

       Copy to
       sundry careless people


The problem is that there should be an unconditional `sp` request at the very end of the `let@print-head` macro, and there isn't.

G. Branden Robinson <gbranden>
Group administrator
Mon 23 Jan 2023 10:52:15 PM UTC, comment #1: 

Clarification:

Even though there's no salutation in type SP, there is a similar problem: the first paragraph directly follows the inside address with no vertical space.

My guess is that both birds can be killed with one stone.

G. Branden Robinson <gbranden>
Group administrator
Mon 23 Jan 2023 10:44:04 PM UTC, original submission:  

Input (from DWB 3.3 mm manual, with slight modifications):


.if \nT=1 .ds Ty BL\"
.if \nT=2 .ds Ty SB\"
.if \nT=3 .ds Ty FB\"
.if \nT=4 .ds Ty SP\"
.ND "April 1, 1990"
.WA "S. P. Lename" "Manager, Product Sales"
SoftPackers, Inc.
25 Bubble Sheet Road
Columbia, Maryland  21046
.WE
.IA "J. J. Jones" "Purchasing Supervisor"
Getem Electronics, Inc.
9 Circuit Lane
St. Louis, Missouri  63101
.IE
.LO SA "Dear Mr. Jones,"
.LT \*(Ty
.P
Thank you for your interest in Softpackers' new
EnviroPack\*(Tm packaging sheets.
.P
I am sure you will find that EnviroPack offers many advantages
over other commercially available packaging materials:
.BL
.LI
EnviroPack is of a lighter-weight material,
thereby reducing shipping costs.
.LI
EnviroPack is less expensive than standard bubble sheets or
styrofoam chips.
.LI
EnviroPack is made of a completely biodegradable
compound so it is environmentally sound,
an important factor
in a world where environmental issues are of great concern.
.LE
.P
We expect this product to enjoy great success and we are
delighted that you will be among the first to try it.
The attached brochure provides additional product information.
.P
You will receive your trial shipment in one week.
If you do not receive this shipment or are not pleased
with the product,
please contact me at 201-567-9876.
.FC
.SG
.NS 3
Brochure
.NE


DWB 3.3 mm consistently puts a blank line after the salutation in all letter types where a salutation is present (all but SP).

groff mm does not.  It should.

I won't show output here as it is repetitious, but you can use


for N in 1 2 3 4; do nroff -rT$N -mm ATTIC/sample-letter-LT.mm > LT-$N.txt; done


to observe it.

(Heirloom Doctools mm behaves badly with all letter types and is not useful for comparison.  DWB screws up interpolation of the `Tm` string, and the line length for letter type BL seems to be too long, but otherwise produces plausible output.  My guess is that nroff output was not tested often or well.)

G. Branden Robinson <gbranden>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-07-10 gbranden StatusReady for Merge Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.24.0
    2023-06-01 gbranden StatusIn Progress Ready for Merge
    2023-05-25 gbranden StatusNone In Progress
        Assigned toNone gbranden
        Summary[mm] omits vertical space after salutation in LT letters [mm] omits vertical space after inside address in LT letters

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code