bugmake - Bugs: bug #63047, --shuffle mode does not work on...

 
 

bug #63047: --shuffle mode does not work on .SECONDEXPANSION targets

Submitter:  Sergei Trofimovich <slyfox>
Submitted:  Sun 11 Sep 2022 08:13:12 PM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Component Version:  4.4 Operating System:  Any
Fixed Release:  4.4 Triage Status:  Small Effort
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 12 Sep 2022 06:10:49 AM UTC, comment #2: 

Applied; thanks Sergei!

 Paul D. Smith <psmith>
Group administrator
Sun 11 Sep 2022 08:30:31 PM UTC, comment #1: 

Posted the patch for review as https://lists.gnu.org/archive/html/bug-make/2022-09/msg00069.html

 Sergei Trofimovich <slyfox>
Sun 11 Sep 2022 08:13:12 PM UTC, original submission:  

Since commit 07eea3aa496184bb763b7306e9de6a40a94605c9 ("[SV 62706] Only second-expand targets that might be built") `make --shuffle` stopped shuffling .SECONDEXPANSION. Example `Makefile`:

.SECONDEXPANSION:
all: $$(var)
%_: ; @echo $@
var = a_ b_ c_

Before (good):

$ make --shuffle=reverse
c_
b_
a_

After (bad):

$ ./make --shuffle=reverse
a_
b_
c_


I'll send a possible fix today.

 Sergei Trofimovich <slyfox>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #53680:  0001-Fix-shuffle-for-SECONDEXPANSION-prerequisites.patch added by slyfox (3KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by slyfox (Submitted the item)

    •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-09-12 psmith Item GroupNone Bug
        StatusNone Fixed
        Open/ClosedOpen Closed
        Component VersionNone 4.4
        Operating SystemNone Any
        Fixed ReleaseNone 4.4
        Triage StatusNone Small Effort
    2022-09-11 slyfox Attached File- Added 0001-Fix-shuffle-for-SECONDEXPANSION-prerequisites.patch, #53680

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.13-da57.
    Corresponding source code