bugGNU roff - Bugs: bug #62975, [mom] mom.am: change '-k' to '-K...

 
 

bug #62975: [mom] mom.am: change '-k' to '-K utf8' in case build can't find uchardet library

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Mon 29 Aug 2022 12:13:13 AM UTC
   
 
Category:  Macro mom Severity:  3 - Normal
Item Group:  Build/Installation Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 03 Sep 2022 12:00:06 AM UTC, comment #2: 


commit 4af85b7ed6e2512be18c72636b84dd698ffbd716
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Mon Aug 29 22:34:28 2022 -0500

    [mom]: Build docs without uchardet dependency.

    * contro/mom/mom.am (MOMPDFMOM): Pass `PDFMOMBIN` '-K utf8', not '-k',
      in case 'configure' didn't find uchardet.

    Fixes <https://savannah.gnu.org/bugs/?62975>.  Thanks to Bjarni Ingi
    Gislason for the report.

    See commit 931c31ab4d, 21 May.


G. Branden Robinson <gbranden>
Group administrator
Tue 30 Aug 2022 03:24:43 AM UTC, comment #1: 

Thanks for the report.  However...

"as the encoding is known and not unknown"

This is not a good enough reason to change the options given to +groff_.

"as it uses more resources than necessary"

This isn't either.  You haven't quantified the marginal cost you characterize.  I predict that the difference as a portion of those consumed by a build of groff, is low to unmeasurable.

An appropriate reason for making this change was covered in a different part of the build in a different commit.


commit 931c31ab4d8e73854bbc14e2a4c68f8b918af302
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat May 21 09:26:20 2022 -0500

    doc/doc.am: Generate meintro_fr.ps more robustly.

    * doc/doc.am (doc/meintro_fr.ps): Call groff with `-K utf8` instead of
      `-k`, in case the "configure" script didn't find uchardet (and
      preconv(1) thus can't auto-detect an encoding).


G. Branden Robinson <gbranden>
Group administrator
Mon 29 Aug 2022 12:13:13 AM UTC, original submission:  

[mom] mom.am: change '-k' to '-K utf8' as the encoding is known and
not unknown

  File "contrib/mom/mom.am"

  Change the option '-k' to '-K utf8' as it uses more resources than
necessary in the line

$(PDFMOMBIN) $(FFLAG) $(MFLAG) -M$(mom_srcdir) -k -p -e -t

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-09-03 gbranden StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2022-08-30 gbranden Item GroupLint Build/Installation
        StatusNone In Progress
        Assigned toNone gbranden
        Planned ReleaseNone 1.23.0
        Summary[mom] mom.am: change '-k' to '-K utf8' as the encoding is known and not unknown [mom] mom.am: change '-k' to '-K utf8' in case build can't find uchardet library

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code