bugGNU roff - Bugs: bug #62833, [PATCH] tty.cpp: prefer showing...


bug #62833: [PATCH] tty.cpp: prefer showing data over opinion

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Fri 29 Jul 2022 01:16:21 AM UTC
Category:  Driver grotty Severity:  1 - Wish
Item Group:  Warning/Suspicious behaviour Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup

Fri 29 Jul 2022 01:16:21 AM UTC, original submission:  

From 7da84c1a23313b3b3dfac0dede125204adf45ca4 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@vortex.is>
Date: Fri, 29 Jul 2022 00:56:54 +0000
Subject: [PATCH] tty.cpp: prefer showing data over opinion

Directory: src/devices/grotty

  Show the data that cause an error message.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@vortex.is>
 src/devices/grotty/tty.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/devices/grotty/tty.cpp b/src/devices/grotty/tty.cpp
index 019791667..2b4d25f56 100644
--- a/src/devices/grotty/tty.cpp
+++ b/src/devices/grotty/tty.cpp
@@ -360,7 +360,8 @@ void tty_printer::add_char(output_character c, int w,
   int hpos = h / font::hor;
   if (hpos < SHRT_MIN || hpos > SHRT_MAX) {
-    error("character with ridiculous horizontal position discarded");
+    error("character with horizontal position %1 discarded while < %2 or "
+          "> %3", hpos, SHRT_MIN, SHRT_MAX);
   int vpos;

Bjarni Ingi Gislason <bjarniig>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by gbranden (Updated the item)
  • -email is unavailable- added by barx (Updated the item)
  • -email is unavailable- added by bjarniig (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.


    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-04-15 barx Item GroupNone Warning/Suspicious behaviour
    2022-10-07 gbranden CategoryDriver - others/general Driver grotty
    2022-07-29 barx Severity3 - Normal 1 - Wish

    Back to the top

    Powered by Savane 3.13-599c.
    Corresponding source code