bugGNU roff - Bugs: bug #62541, in-tree documents should make(1)...

 
 

bug #62541: in-tree documents should make(1) depend on macro files they explicitly use

Submitter:  None
Submitted:  Mon 30 May 2022 02:42:30 AM UTC
   
 
Category:  General Severity:  3 - Normal
Item Group:  Build/Installation Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.24.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 10 Jul 2023 09:05:10 AM UTC, comment #5: 


commit 4ee1f372205aeae9799ee41312ee1ee43531fb20
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu Apr 6 22:55:27 2023 -0500

    [doc]: Align with Savannah #62541 fix (4/4).

    [doc]: Abstract document dependencies on the mom package.

    * doc/doc.am (doc/automake.pdf): Replace dependency with new macro
      `TMAC_PACKAGE_MOM`.

    Aligns with <https://savannah.gnu.org/bugs/?62541> (4/4).

commit d31d9378b150a70af1cce006feb0dc511b7459a3
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu Apr 6 22:53:23 2023 -0500

    [mom]: Align with Savannah #62541 fix (3/4).

    * contrib/mom/mom.am (TMAC_PACKAGE_MOM): Define new convenience macro
      for the benefit of other groff documents.

    Aligns with <https://savannah.gnu.org/bugs/?62541> (3/4).

commit f785a9e876fee36583841cf12ac5a6b5e65cd1ac
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Wed Apr 5 09:22:58 2023 -0500

    [doc]: Fix Savannah #62541 (2/4).

    [doc]: Add document deps on the ms package.

    * tmac/tmac.am (TMAC_PACKAGE_MS): Define new macro comprising the files
      of the ms package.

    * doc/doc.am (doc/ms.ps, doc/webpage.ps, doc/pic.html, doc/pic.ps): Add
      dependency on new macro.

    Fixes <https://savannah.gnu.org/bugs/?62541> (2/4).

commit bcd182e290b2261d64c16af324f8317404a2faa1
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Mon Apr 3 20:05:17 2023 -0500

    [doc]: Fix Savannah #62541 (1/4).

    [doc]: Add document deps on the "me" package.

    * tmac/tmac.am (TMAC_PACKAGE_ME): Define new macro comprising the files
      of the "me" package.
    * doc/doc.am (doc/grnexmpl.ps, doc/meintro.ps, doc/meintro_fr.ps)
      (doc/meref.ps): Add dependency on new macro.

    Fixes <https://savannah.gnu.org/bugs/?62541> (1/4).


 G. Branden Robinson <gbranden>
Group administrator
Tue 11 Apr 2023 03:58:00 AM UTC, comment #4: 

Re-setting status--tricked by a stale browser tab.

 G. Branden Robinson <gbranden>
Group administrator
Fri 07 Apr 2023 04:46:21 PM UTC, comment #3: 


commit a7b30712e98dc50616e097e7fa8b3b6adc652d0c
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu Apr 6 22:55:27 2023 -0500

    [doc]: Align with Savannah #62541 fix (4/4).

    [doc]: Abstract document dependencies on the mom package.

    * doc/doc.am (doc/automake.pdf): Replace dependency with new macro
      `TMAC_PACKAGE_MOM`.

    Aligns with <https://savannah.gnu.org/bugs/?62541> (4/4).

commit 46359d9592b1e15116bd3de680ada7171f9de917
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu Apr 6 22:53:23 2023 -0500

    [mom]: Align with Savannah #62541 fix (3/4).

    * contrib/mom/mom.am (TMAC_PACKAGE_MOM): Define new convenience macro
      for the benefit of other groff documents.

    Aligns with <https://savannah.gnu.org/bugs/?62541> (3/4).

commit 2e9e39acd99fe66f283c285280f67f7fce1f06d1
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Wed Apr 5 09:22:58 2023 -0500

    [doc]: Fix Savannah #62541 (2/4).

    [doc]: Add document deps on the ms package.

    * tmac/tmac.am (TMAC_PACKAGE_MS): Define new macro comprising the files
      of the ms package.

    * doc/doc.am (doc/ms.ps, doc/webpage.ps, doc/pic.html, doc/pic.ps): Add
      dependency on new macro.

    Fixes <https://savannah.gnu.org/bugs/?62541> (2/4).

commit a1028aa3cde04194d1155e7a8ce337bf2ce9418b
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Mon Apr 3 20:05:17 2023 -0500

    [doc]: Fix Savannah #62541 (1/4).

    [doc]: Add document deps on the "me" package.

    * tmac/tmac.am (TMAC_PACKAGE_ME): Define new macro comprising the files
      of the "me" package.
    * doc/doc.am (doc/grnexmpl.ps, doc/meintro.ps, doc/meintro_fr.ps)
      (doc/meref.ps): Add dependency on new macro.

    Fixes <https://savannah.gnu.org/bugs/?62541> (1/4).


 G. Branden Robinson <gbranden>
Group administrator
Mon 30 May 2022 05:50:10 PM UTC, comment #2: 

This was a deliberate choice; I was going to close this ticket as invalid.

My reasoning was that because the macro files are part of the source distribution, nothing cleans them and they are therefore "guaranteed to exist", barring careless destruction by the person building.

However, on reflection, this stance is not consistent with the way Makefiles are generally written.  .o files depend on .c files (that are part of source distributions) all the time.

Further, when undertaking changes to the macro files themselves, the documents that use them should be rebuilt.  This is one way that errors in development can be caught swiftly.

So I'll do this.


G. Branden Robinson <gbranden>
Group administrator
Mon 30 May 2022 02:46:56 AM UTC, comment #1: 

  Forgot to login

 Bjarni Ingi Gislason <bjarniig>
Mon 30 May 2022 02:42:30 AM UTC, original submission:  

Subject: Makefile: creation of man pages is not let to depend on the
used macros

  Lines with "-m" do not have a prerequisite for the used macro file,
for example

doc/groff-man-pages.pdf: $(GROFF_MAN_PAGES_ALL) eqn pic tbl
        $(GROFF_V)$(DOC_GROFF) -pet -Tpdf -P-e -mandoc -rC1 \

  Here "mandoc" uses at least "tmac/an.tmac" or "tmac/doc.tmac".

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bjarniig (Posted a comment)

    •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-07-10 gbranden StatusReady for Merge Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.24.0
    2023-04-11 gbranden StatusIn Progress Ready for Merge
    2023-04-11 gbranden StatusReady for Merge In Progress
    2023-04-07 gbranden StatusIn Progress Ready for Merge
    2023-04-07 gbranden StatusConfirmed In Progress
    2022-06-01 gbranden StatusIn Progress Confirmed
    2022-05-30 gbranden SummaryMakefile: creation of man pages is not let to depend on the used macros in-tree documents should make(1) depend on macro files they explicitly use
    2022-05-30 gbranden StatusNone In Progress
        Assigned toNone gbranden

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.14-8eb0.
    Corresponding source code