bugmake - Bugs: bug #62514, Regression. make ignores cli flags.

 
 

bug #62514: Regression. make ignores cli flags.

Submitter:  Dmitry Goncharov <dgoncharov>
Submitted:  Tue 24 May 2022 12:16:45 AM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Component Version:  4.4 Operating System:  Any
Fixed Release:  4.4 Triage Status:  Medium Effort
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 09 Jul 2022 04:45:25 PM UTC, comment #1: 

Applied this with a few tweaks to the tests.

Thanks!

 Paul D. Smith <psmith>
Group administrator
Tue 24 May 2022 12:16:45 AM UTC, original submission:  

Commit f2771aa614d3a826b70973217c33f605fb4cd0c2 introduced function reset_switches.
reset_switches wipes out certain flags specified on the command line.

/usr/bin/make is make-4.3.
make is the latest make from git.


$ cat makefile
MAKEFLAGS=-B
all:; $(info MAKEFLAGS=$(MAKEFLAGS))
$ /usr/bin/make -s
MAKEFLAGS=Bs
$ make -s
MAKEFLAGS=B
make: 'all' is up to date.
$


Flag '-s' is missing from MAKEFLAGS.
Also, the last output from make is "make: 'all' is up to date.".
This tells that '-s' is not in effect.
Similarly, reset_switches wipes out certain other options, e.g. -k, -S, -l<value>, --debug=<value>, etc.
This patch deletes reset_switches and replaces it with a piece of code in detect_switches to filter out duplicates.

 Dmitry Goncharov <dgoncharov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #53246:  sv62514_fix.diff added by dgoncharov (5KiB - text/x-patch)
file #53247:  sv62514_test.diff added by dgoncharov (3KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by dgoncharov (Submitted the item)

    •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-07-09 psmith Fixed ReleaseNone 4.4
        Triage StatusNone Medium Effort
    2022-07-09 psmith StatusNone Fixed
        Open/ClosedOpen Closed
    2022-05-24 dgoncharov Attached File- Added sv62514_fix.diff, #53246
        Attached File- Added sv62514_test.diff, #53247

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.13-da57.
    Corresponding source code