bugmake - Bugs: bug #62174, fix test functions/shell on aix.

 
 

bug #62174: fix test functions/shell on aix.

Submitter:  Dmitry Goncharov <dgoncharov>
Submitted:  Sat 12 Mar 2022 11:14:40 PM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  4.4 Operating System:  None
Fixed Release:  4.4 Triage Status:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 06 Nov 2022 01:41:46 PM UTC, comment #5: 

I can confirm the current code works. Thank you.

 Dmitry Goncharov <dgoncharov>
Wed 26 Oct 2022 05:49:18 PM UTC, comment #4: 

Hm.  the code tries to reset the locale to "C" before it detects any of this stuff.  I guess maybe the method it uses (calling POSIX::setlocale()) isn't sufficient?

OK I'll address this.

I think the idea was that we didn't want to change the locale for the top-level Perl, so that any messages generated by it would be in the correct locale.  We only wanted to set the locale inside the tests.  That's why we try to set the locale to "C", then set it back again after we are done.

Maybe that's not worthwhile.

 Paul D. Smith <psmith>
Group administrator
Tue 25 Oct 2022 10:31:30 PM UTC, comment #3: 

i guess this fell through the cracks. Paul, can you please have a look at sv62174_fix2.diff?

 Dmitry Goncharov <dgoncharov>
Thu 28 Apr 2022 12:22:21 AM UTC, comment #2: 

Paul, the changes that were introduced in toplevel to set LANG=C do not have desired effect, because run_make_tests.pl sets $ERR_command_not_found before &toplevel is called.

Since you didn't like removing LANG from environment, i attached another patch (sv62174_fix2.diff) which sets LANG=C before $ERR_command_not_found is initialized.

 Dmitry Goncharov <dgoncharov>
Sun 24 Apr 2022 06:21:12 PM UTC, comment #1: 

Fixed.  Thanks.

 Paul D. Smith <psmith>
Group administrator
Sat 12 Mar 2022 11:14:40 PM UTC, original submission:  

Presence of LANG=en_US in the env causes functions/shell test 8 to fail on aix.



functions/shell ......................................... FAILED (8/9 passed)

1 Test in 1 Category Failed (See .diff* files in work dir for details) :-(

$ cat work/functions/shell.diff.8
*** work/functions/shell.base.8 Sat Mar 12 12:30:35 2022
--- work/functions/shell.log.8  Sat Mar 12 12:30:35 2022
***************
*** 1 ****
! 127: /bin/sh: bad-command:  not found.
--- 1 ----
! 127: /bin/sh: bad-command:  not found



$ LANG=en_US /bin/sh -c 'bad-command'
/bin/sh: bad-command:  not found.
$ LANG= /bin/sh -c 'bad-command'
/bin/sh: bad-command:  not found


 Dmitry Goncharov <dgoncharov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #53153:  sv62174_fix2.diff added by dgoncharov (551B - text/x-patch)
file #52983:  test_functions_shell_fix_on_aix.diff added by dgoncharov (596B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by dgoncharov (Submitted the item)

    •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-04-28 dgoncharov Attached File- Added sv62174_fix2.diff, #53153
    2022-04-24 psmith StatusNone Fixed
        Assigned toNone psmith
        Open/ClosedOpen Closed
        Fixed ReleaseNone 4.4
    2022-03-12 dgoncharov Attached File- Added test_functions_shell_fix_on_aix.diff, #52983

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.13-da57.
    Corresponding source code