bugmake - Bugs: bug #62088, Avoid re-exec due to stdin

 
 

bug #62088: Avoid re-exec due to stdin

Submitter:  Dmitry Goncharov <dgoncharov>
Submitted:  Sun 20 Feb 2022 01:26:47 PM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  4.4 Operating System:  Any
Fixed Release:  4.4 Triage Status:  Small Effort
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 27 Feb 2022 11:12:51 PM UTC, comment #2: 

Thanks Dmitry I applied this patch, and also wrote a test for this.

 Paul D. Smith <psmith>
Group administrator
Sun 20 Feb 2022 01:32:01 PM UTC, comment #1: 

Indeed, the fix for SV 60595 introduced an undesired change, specifically, causes make to re-execute when make code is read from the standard input.
This is not related to lowdown. No need for any package or makefile to reproduce. In fact, the following is sufficient


$ printf 'all:; $(info hello)' | make -f -


 Dmitry Goncharov <dgoncharov>
Sun 20 Feb 2022 01:26:47 PM UTC, original submission:  

A user reported the following

"Noticed the regression on lowdown-0.10.0 upstream package.

Here is a complete trigger:

    $ printf 'all:\n\techo $(CC)' | make -sf -

[good] GNU make 4.3 works as expected:

    $ printf 'all:\n\techo $(CC)' | make -sf -
    cc

[bad] GNU make from git loops indefinitely in re-execution:

    $ printf 'all:\n\techo $(CC)' | ./make -sf -
    <hung>

Curiously space separation workaround is enough to
get the result:

    $ printf 'all:\n\techo $(CC)' | ./make -s -f -
    cc

Bitsect points at commit 7c4e6b0299 "[SV 60595] Restart
whenever any makefile is rebuilt"."

The original bug report is here
https://lists.gnu.org/archive/html/bug-make/2022-02/msg00037.html.

 Dmitry Goncharov <dgoncharov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52894:  sv62088_fix.diff added by dgoncharov (935B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by slyfox
  • -email is unavailable- added by dgoncharov (Submitted the item)

    •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-02-27 psmith StatusNone Fixed
        Assigned toNone psmith
        Open/ClosedOpen Closed
        Operating SystemNone Any
        Fixed ReleaseNone 4.4
        Triage StatusNone Small Effort
    2022-02-20 slyfox Carbon-Copy- Added slyfox
    2022-02-20 dgoncharov Attached File- Added sv62088_fix.diff, #52894

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.13-da57.
    Corresponding source code