bugGNU roff - Bugs: bug #62062, [sboxes] uses a few ms registers...

 
 

bug #62062: [sboxes] uses a few ms registers unconditionally

Submitter:  G. Branden Robinson <gbranden>
Submitted:  Wed 16 Feb 2022 08:27:15 AM UTC
   
 
Category:  Macro package - others/general Severity:  3 - Normal
Item Group:  Warning/Suspicious behaviour Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 28 Mar 2022 04:12:16 PM UTC, comment #1: 


commit c20cc5c2a36b91afd100112b828392399fb10fd7
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Tue Mar 29 02:08:38 2022 +1100

    [sboxes,man]: Fix Savannah #62062.

    * contrib/sboxes/msboxes.ms.in:
    * man/groff_tmac.7.man (Auxiliary packages): Tweak sboxes documentation
      to imply ms dependency.

    Fixes <https://savannah.gnu.org/bugs/?62062>.

commit 7b3a7b2eecd6970e9478a6d7114a5761067a1bdb
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Tue Mar 29 02:05:24 2022 +1100

    Tweak sboxes documentation to imply ms dependency.

    Imply harder!

commit b0441c55f0a7ac17f11ef6bddb4186315c38f949
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Tue Mar 29 02:01:32 2022 +1100

    Revert "[sboxes]: Stop requiring ms package."

    This reverts commit 26dc01acc81b363e505a95574126b66f96a9445c.

    Things go rapidly pear-shaped in the absence of defined header and
    footer and margin amounts when a box abuts where they should be, so just
    depend on ms.


G. Branden Robinson <gbranden>
Group administrator
Wed 16 Feb 2022 08:27:15 AM UTC, original submission:  

sboxes.tmac uses a few ms registers selectively.  However, if they're not set, it doesn't seem to ruin the package's utility, at least according to the crude experiments I did.


$ tg -msboxes -z EXPERIMENTS/sbox.groff
troff: backtrace: '/home/branden/src/GIT/groff/build/../contrib/sboxes/sboxes.tmac':118: macro 'BOXSTART'
troff: backtrace: file 'EXPERIMENTS/sbox.groff':4
troff:EXPERIMENTS/sbox.groff:4: warning: register '0:li' not defined
troff: backtrace: '/home/branden/src/GIT/groff/build/../contrib/sboxes/sboxes.tmac':121: macro 'BOXSTART'
troff: backtrace: file 'EXPERIMENTS/sbox.groff':4
troff:EXPERIMENTS/sbox.groff:4: warning: register 'FM' not defined
troff: backtrace: '/home/branden/src/GIT/groff/build/../contrib/sboxes/sboxes.tmac':122: macro 'BOXSTART'
troff: backtrace: file 'EXPERIMENTS/sbox.groff':4
troff:EXPERIMENTS/sbox.groff:4: warning: register 'HM' not defined
troff: backtrace: '/home/branden/src/GIT/groff/build/../contrib/sboxes/sboxes.tmac':124: macro 'BOXSTART'
troff: backtrace: file 'EXPERIMENTS/sbox.groff':4
troff:EXPERIMENTS/sbox.groff:4: warning: register 'bx*PD' not defined


We can probably shift all these into bx* bespoke registers, perhaps with more generalized names, initializing them with the values of the ms registers if those are defined.

Maybe we should rename the package's name space prefix to "sboxes" while we're at it?

If that doesn't work, I guess I'll need to revert a recent commit after all.


commit 26dc01acc81b363e505a95574126b66f96a9445c
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sun Feb 6 02:50:01 2022 +1100

    [sboxes]: Stop requiring ms package.

    * sboxes.tmac: Stop requiring ms package.  As the documentation says,
      it's not necessary; sboxes will simply take advantage of it if it is.
      Problem introduced by me in commit f1f047013, 17 October.  Append to
      ms's `fn@print-sep` and `par*start` macros only if the `GS` register
      exists, so that warnings aren't thrown when ms is not loaded.


G. Branden Robinson <gbranden>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-03-28 gbranden StatusIn Progress Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.23.0
    2022-03-28 gbranden StatusNone In Progress
        Assigned toNone gbranden

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code