bugGNU roff - Bugs: bug #62055, [pdfpic] should handle temporary...

 
 

bug #62055: [pdfpic] should handle temporary files as the rest of groff does

Submitter:  G. Branden Robinson <gbranden>
Submitted:  Tue 15 Feb 2022 12:53:46 AM UTC
   
 
Category:  Macro package - others/general Severity:  1 - Wish
Item Group:  Feature change Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 21 Feb 2022 11:18:05 AM UTC, comment #1: 


commit afc1999af86d95d0dfce22235c8bf4c02154c917
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Tue Feb 15 19:30:50 2022 +1100

    [pdfpic]: Fix Savannah #62055 for Unix systems.

    * tmac/pdfpic.tmac: Search for temporary directories as groff(1) does,
      instead of going straight to /tmp.

      (pdfpic@get-temporary-directory): New function checks each of its
      arguments for validity as a temporary directory; if one is found, its
      name is left in `pdfpic*temporary-directory`.

      (pdfpic@cleanup): Remove strings `pdfpic*temporary-directory` and
      `pdfpic*temporary-file`.

      (PDFPIC): Call `pdfpic@get-temporary-directory`, using the contents of
      the environment variables $GROFF_TMPDIR and $TMPDIR, and then /tmp, in
      that order.  Store the temporary file name in string
      `pdfpic*temporary-file`.  Use this string in subsequent `sy` and `so`
      requests.

    Fixes <https://savannah.gnu.org/bugs/?62055> for Unix systems.

commit 24900cf6d73088e4b00c797221ede1b5ac36d863
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Tue Feb 15 19:47:25 2022 +1100

    [pdfpic]: Fix Savannah #62055 for Cygwin/MinGW.

    * tmac/pdfpic.tmac: Add support for Cygwin/MinGW temporary directory
      conventions.


G. Branden Robinson <gbranden>
Group administrator
Tue 15 Feb 2022 12:53:46 AM UTC, original submission:  

The use of temporary files in pdfpic.tmac alarms me a bit.

We go straight to /tmp with an easily predictable file name based on the process ID.

Now, we do tell people we only run in "unsafe mode", so people have fair warning, but we also have lots of documentation (starting with groff(1)) of what temporary directories groff uses and pdfpic.tmac skips over all of that.  No $TMPDIR, no $GROFF_TMPDIR, nothing...just /tmp.

The issue is made thornier by the fact that we're supposed to (according to our documentation) check $TEMP and $TMP (in that order) after $GROFF_TMPDIR and $TMPDIR...on Windows systems.

Nevertheless I have a change in progress.


G. Branden Robinson <gbranden>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-02-21 gbranden Open/ClosedOpen Closed
    2022-02-21 gbranden StatusIn Progress Fixed
        Planned ReleaseNone 1.23.0
    2022-02-15 barx Carbon-CopyRemoved 93119 -
    2022-02-15 barx Summary[pdpic] should handle temporary files as the rest of groff does [pdfpic] should handle temporary files as the rest of groff does

    Back to the top

    Powered by Savane 3.13-0329.
    Corresponding source code