bugLibreJS - Bugs: bug #61893, SPDX license recognition (was:...

 
 

bug #61893: SPDX license recognition (was: Script license is unknown even if script is AGPL 3.0)

Submitter:  None
Submitted:  Fri 21 Jan 2022 02:55:12 PM UTC
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Fri 29 Apr 2022 07:15:04 AM UTC, comment #4: 

comment #3:

>
> comment #1:
> > This is also happening on my friend's site, https://trinity.moe/, in all of the files in the /js/ directory. They use the stylized comments like yours, so it may have to do with that.
>
> This does look like the scripts shouldn't be blocked:
>
> - https://www.trinity.moe/js/quotes.js
> - https://www.trinity.moe/js/cookies.js
>
> I will take a look later.


Turned out librejs could not handle /* @license-end */ properly, and for external scripts, it will treat comments as nontrivial. This will be fixed in the next release:

https://git.savannah.gnu.org/cgit/librejs.git/commit/?id=e86693c682d15a29efd936c2b185e121a0c9ffda
https://git.savannah.gnu.org/cgit/librejs.git/commit/?id=3dafc83753fbabc8d80540e05cf1e374ae73f4fa

So what remains is SPDX license recognition.

Yuchen Pei <ycp>
Project Administrator
Mon 18 Apr 2022 04:51:13 AM UTC, comment #3: 

comment #1:

> This is also happening on my friend's site, https://trinity.moe/, in all of the files in the /js/ directory. They use the stylized comments like yours, so it may have to do with that.


This does look like the scripts shouldn't be blocked:

- https://www.trinity.moe/js/quotes.js
- https://www.trinity.moe/js/cookies.js

I will take a look later.

Yuchen Pei <ycp>
Project Administrator
Mon 18 Apr 2022 04:44:49 AM UTC, comment #2: 

original submission:

> Affected script: https://paulgo.io/static/themes/simple/js/searxng.min.js
>
> How to get this bug:
>
> 1. Visit https://paulgo.io/
> 2. Search anything
> 3. Now LibreJS will block loading of the affected script, even if Script itself is AGPL 3.0


The blocked script is annotated using SPDX:
https://paulgo.io/static/themes/simple/js/searxng.min.js

/**

  • @license
  • (C) Copyright Contributors to the SearXNG project.
  • (C) Copyright Contributors to the searx project (2014 - 2021).
  • SPDX-License-Identifier: AGPL-3.0-or-later

*/

SPDX comments are not supported by LibreJS yet, but there are plans on adding the support.

Yuchen Pei <ycp>
Project Administrator
Wed 23 Feb 2022 03:54:31 AM UTC, comment #1: 

This is also happening on my friend's site, https://trinity.moe/, in all of the files in the /js/ directory. They use the stylized comments like yours, so it may have to do with that.

Anonymous
Fri 21 Jan 2022 02:55:12 PM UTC, original submission:  

Affected script: https://paulgo.io/static/themes/simple/js/searxng.min.js

How to get this bug:

1. Visit https://paulgo.io/
2. Search anything
3. Now LibreJS will block loading of the affected script, even if Script itself is AGPL 3.0

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ycp (Posted a comment)
  • -email is unavailable- added by ycp
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-04-29 ycp Assigned toycp None
        SummaryScript license is unknown even if script is AGPL 3.0 SPDX license recognition (was: Script license is unknown even if script is AGPL 3.0)
    2022-04-18 ycp Assigned toNone ycp
    2022-04-18 ycp Carbon-Copy- Added -email is unavailable-

    Back to the top


    Powered by Savane 3.9