bugGNU roff - Bugs: bug #61878, [tbl] should warn when a boxed,...

 
 

bug #61878: [tbl] should warn when a boxed, non-kept table is too big

Submitter:  G. Branden Robinson <gbranden>
Submitted:  Thu 20 Jan 2022 09:04:02 AM UTC
   
 
Category:  Preprocessor tbl Severity:  3 - Normal
Item Group:  Warning/Suspicious behaviour Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 07 Dec 2022 09:34:20 AM UTC, comment #1: 


commit f9e095634718bf6f3ac351ff95bce980e1be6b9a
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Wed Dec 7 00:32:36 2022 -0600

    [tbl]: Regression-test Savannah #61878.

    * src/preproc/tbl/tests/warn-on-long-boxed-unkept-table.sh: Do it.
    * src/preproc/tbl/tbl.am (tbl_TESTS): Run test.

    Test fails at this commit.

commit ebf4ff1be1401dac0163b719bb0be0f0945da448
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Wed Dec 7 00:42:19 2022 -0600

    [tbl]: Fix Savannah #61878.

    * src/preproc/tbl/table.cpp: Define new preprocessor macro,
      `STARTING_PAGE_REG`.

      (table::define_bottom_macro): Have the formatter issue a warning if an
      unkept, boxed table ends on a different page than it began.

      (table::do_top): Save current page number when table begins.

    Fixes <https://savannah.gnu.org/bugs/?61878>.


G. Branden Robinson <gbranden>
Group administrator
Thu 20 Jan 2022 09:04:02 AM UTC, original submission:  

This scenario does not produce a diagnostic.  It should.


$ cat EXPERIMENTS/tbl-diagnostic-2.groff
.pl 2v
.vs 3v
.TS
nokeep box;
L.
1
.TE
$ nroff -Tascii -t EXPERIMENTS/tbl-diagnostic-2.groff
----


 1
+--+
|  |
|  |


I have no immediate plans to work on this.  It would involve
messing around with the giant blast of *roff spew in
table::init_output().  The scope of the conditions seem a bit
broad.  Under the "nokeep" constraint, it might be possible to
warn only after ugly output has been emitted, but that's okay.

G. Branden Robinson <gbranden>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-12-07 gbranden StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2022-12-07 gbranden StatusNone In Progress
        Assigned toNone gbranden
        Planned ReleaseNone 1.23.0

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code