bugmake - Bugs: bug #61763, [PATCH] glob: Do not use realloc...

 
 

bug #61763: [PATCH] glob: Do not use realloc wrapper on FreeBSD

Submitted by:  Jessica Clarke <jrtc27>
Submitted on:  Tue 04 Jan 2022 03:44:02 PM UTC
 
Severity:  3 - Normal Item Group:  Enhancement
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
Component Version:  SCM Operating System:  POSIX-Based
Fixed Release:  None Triage Status:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Tue 18 Jan 2022 12:20:23 AM UTC, comment #1: 

Unfortunately the glob.c that comes from GNU make was copied from gnulib and isn't really maintained by GNU make.  Doubly-unfortunately the glob.c that now appears in the current gnulib is massively different AND cannot be used in any environment that doesn't support a complete autoconf deployment (that is, a full configure script with all the POSIX utilities that configure requires).

Since GNU make builds on, and is used by, DOS, Windows, and VMS users, none of which have the ability to run configure natively, we're sort of between a rock and a hard place.

We'll have to decide whether to keep the existing glob implementation, which is extremely outdated and contains some known bugs as well as build issues such as the one you raise, and tweak it, or replace it with the new implementation and figure out how to handle the systems where configure can't be invoked.

Paul D. Smith <psmith>
Project Administrator
Tue 04 Jan 2022 03:44:02 PM UTC, original submission:  

FreeBSD's realloc, like any you're likely to encounter these days, is
totally fine for make's uses. The current my_realloc wrapper, by using
char * instead of void *, results in -Wincompatible-pointer-type warning
spew as, for example, it's passed char **'s, but only void * is treated
specially when it comes to warning about implicit conversions.

  • lib/glob.c (my_realloc): Guard with !defined _FreeBSD_
Jessica Clarke <jrtc27>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by jrtc27 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-04 jrtc27 Attached File- => Added 0001-glob-Do-not-use-realloc-wrapper-on-FreeBSD.patch, #52612

    Back to the top


    Powered by Savane 3.9