bugGNU roff - Bugs: bug #61758, [grog] doesn't handle auxiliary...

 
 

bug #61758: [grog] doesn't handle auxiliary package -m arguments correctly

Submitter:  G. Branden Robinson <gbranden>
Submitted:  Mon 03 Jan 2022 05:10:59 PM UTC
   
 
Category:  Utilities Severity:  3 - Normal
Item Group:  Incorrect behaviour Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 11 Jan 2022 11:35:07 AM UTC, comment #1: 


commit 192a494e73741c7b0aa6df608e334bab21044eef
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Tue Jan 4 04:39:56 2022 +1100

    [grog]: Handle auxiliary `-m` options correctly.

    * src/utils/grog/grog.pl: Handle auxiliary macro package arguments
      correctly.

      (process_arguments): Don't append the argument to the '-m' option to
      the command line; requested macro packages have dedicated logic.

      (construct_command): When iterating through requested package list,
      assume each element is an auxiliary package unless it matches an
      element in the list of main packages.  If the assumption holds, append
      the package name to a new list, `auxiliary_package_argument` (prefixed
      with '-m').  Push this list onto the command line after any main
      package.

      Also rename `$selected_main_package` to `$main_package` for brevity,
      and drop unused global lists `m` and `supplemental_package`.

    Fixes <https://savannah.gnu.org/bugs/?61758>.


G. Branden Robinson <gbranden>
Group administrator
Mon 03 Jan 2022 05:10:59 PM UTC, original submission:  

Apparently I didn't test the use of user-specified supplemetary
macro packages after my big grog refactor last year.

This isn't a regression, because grog from 1.22.4 behaved badly
with them as well.

Nevertheless, this misbehavior is too crap to let it survive.


$ ./build/grog -Tutf8 -b -ww -P-i -rU1 -m cs build/tmac/groff_me.7
groff -Tutf8 -b -ww -P-i -rU1 cs -t -man build/tmac/groff_me.7
$ ./build/grog -Tutf8 -b -ww -P-i -rU1 -mcs build/tmac/groff_me.7
groff -Tutf8 -b -ww -P-i -rU1 -t -man build/tmac/groff_me.7


Pretty wretched.

I have a fix in preparation; need to write a couple of test
cases to capture the above.

G. Branden Robinson <gbranden>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-11 gbranden StatusIn Progress Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.23.0

    Back to the top

    Powered by Savane 3.13-0329.
    Corresponding source code