bugGNU Wget - Bugs: bug #61733, dot_finish() doesn't print the...

 
 

bug #61733: dot_finish() doesn't print the newline when wget is run with the --no-verbose option

Submitter:  None
Submitted:  Mon 27 Dec 2021 03:05:03 PM UTC
 
Category:  User Interface Severity:  3 - Normal
Priority:  5 - Normal Status:  Fixed
Privacy:  Public Assigned to:  None
Originator Name:  Nik Soggia Originator Email:  -email is unavailable-
Open/Closed:  Closed Release:  trunk
Operating System:  GNU/Linux Reproducibility:  Every Time
Fixed Release:  None Planned Release:  None
Regression:  None Work Required:  None
Patch Included:  Yes
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Sat 15 Jan 2022 11:03:31 PM UTC, comment #1: 

Pushed the change.
Thank you for your contribution!

Darshit Shah <darnir>
Project Administrator
Mon 27 Dec 2021 03:05:03 PM UTC, original submission:  

Here is how to reproduce the bug:

$ wget --no-verbose --show-progress --progress=dot:giga https://ftp.gnu.org/gnu/wget/wget-1.21.2.tar.lz

     0K ..                                 100% 2,18M=1,0s2021-12-27 16:03:00 URL:https://ftp.gnu.org/gnu/wget/wget-1.21.2.tar.lz [2407790/2407790] -> "wget-1.21.2.tar.lz" [1]

The problem lies in the fact dot_finish() prints the newline when verbosity is at least "normal" instead of always doing it.
I attach my proposed solution.
Cheers,

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52572:  wget-1.21.2.patch added by None (402B - text/x-patch - always print the end of line in dot_finish())

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by darnir (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-15 darnir StatusNone Fixed
        Open/ClosedOpen Closed
        ReleaseNone trunk
    2021-12-27 None Attached File- Added wget-1.21.2.patch, #52572

    Back to the top


    Powered by Savane 3.9