bugGNU troff - Bugs: bug #60971, [grohtml] uses inconsistent image...

 
 

bug #60971: [grohtml] uses inconsistent image file name stems

Submitted by:  G. Branden Robinson <gbranden>
Submitted on:  Mon 26 Jul 2021 01:30:05 PM UTC  
 
Category:  Device grohtml Severity:  2 - Minor
Item Group:  Incorrect behaviour Status:  Fixed
Privacy:  Public Assigned to:  G. Branden Robinson <gbranden>
Open/Closed:  Closed Planned Release:  1.23.0

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 27 Jul 2021 12:43:25 AM UTC, comment #1: 

The second command in my original submission should have read:

$ ./build/test-groff -Thtml -t -man -P-I -P groff_char.7 build/man/groff_char.7

Anyway, it's fixed now.

commit c71b4ef4aa46f9264751df37ffac4fdf796c45eb
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Tue Jul 27 00:10:49 2021 +1000

    [grohtml]: Fix Savannah #60971.

    * src/preproc/html/pre-html.cpp (makeFileName): Consistently put a dash
      at the end of `macroset_template` whether the image file name stem is
      user-supplied or the default.  Stop adding the dash before the image
      number in `image_template` instead.  This makes the image file name
      format reliable whether the image needs to be subdivided (eqn) or not
      (tbl).

    Fixes <https://savannah.gnu.org/bugs/?60971>.

G. Branden Robinson <gbranden>
Project AdministratorIn charge of this item.
Mon 26 Jul 2021 01:30:05 PM UTC, original submission:  

This took forever to track down.

Image stems generated from the "macroset", and those from "images" (they're all images) are inconsistently; the former get a dash before the image number and the latter don't.

In practical terms this is easier to see when comparing two man pages: one that uses tbl and another that uses eqn.

$ ./build/test-groff -Thtml -e -man -P-I -P groff_diff.7 build/man/groff_diff.7
$ ls groff_diff.7*png | head
groff_diff.7-10.png
groff_diff.7-11.png
groff_diff.7-12.png
groff_diff.7-13.png
groff_diff.7-14.png
groff_diff.7-15.png
groff_diff.7-16.png
groff_diff.7-17.png
groff_diff.7-18.png
groff_diff.7-19.png
$ ./build/test-groff -Thtml -e -man -P-I -P groff_char.7 build/man/groff_char.7
$ ls groff_char.7*png | head
groff_char.710.png
groff_char.711.png
groff_char.712.png
groff_char.713.png
groff_char.714.png
groff_char.715.png
groff_char.716.png
groff_char.717.png
groff_char.718.png
groff_char.719.png

I have a fix in preparation.

G. Branden Robinson <gbranden>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-07-27 gbranden StatusIn Progress => Fixed
        Open/ClosedOpen => Closed
        Planned ReleaseNone => 1.23.0

    Back to the top


    Powered by Savane 3.7