bugGNU troff - Bugs: bug #60915, [mm] aligns date wrong if ms cover...

 
 

bug #60915: [mm] aligns date wrong if ms cover sheet used with no firm defined

Submitted by:  G. Branden Robinson <gbranden>
Submitted on:  Tue 13 Jul 2021 12:58:21 PM UTC  
 
Category:  Macro - mm Severity:  3 - Normal
Item Group:  Incorrect behaviour Status:  Fixed
Privacy:  Public Assigned to:  G. Branden Robinson <gbranden>
Open/Closed:  Closed Planned Release:  1.23.0

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 17 Jul 2021 12:59:26 AM UTC, comment #2: 

commit 706a904534e0aefd66c8a0ae15896e946cc4d773
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Jul 17 07:10:52 2021 +1000

    [mm]: Fix Savannah #60915.

    * mm/ms.cov (cov@print-firm): Do nothing if the `cov*firm` string is not
      defined.  Silences a `mac` warning and prevents the document date from
      being incorrectly aligned.

    Fixes <https://savannah.gnu.org/bugs/?60915>.

commit da64886e77f0cb6ab50d305e7b375a7a9d7678a2
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Jul 17 07:39:08 2021 +1000

    [mm]: Add regression test for Savannah #60915.

    Warning: test fails at this commit.

G. Branden Robinson <gbranden>
Project AdministratorIn charge of this item.
Fri 16 Jul 2021 09:16:42 PM UTC, comment #1: 

This bug also causes the date to be centered instead of left-aligned.  This is incorrect, because if you supply a firm with the .AF macro, the date suddenly becomes left-aligned.  This is because of the .ce request in `cov@print-firm`.

Updating Item Group and Severity accordingly.

G. Branden Robinson <gbranden>
Project AdministratorIn charge of this item.
Tue 13 Jul 2021 12:58:21 PM UTC, original submission:  

The groff_mm man page says under the COVER macro description that only a title (TL) and author (AU) are required, but the ms.cov file assumes that the string cov*firm is defined, and outputs vertical space before interpolating this potentially undefined string, causing a warning when "name" warnings are enabled.

It would be better to test for cov*firm being defined and only execute the body of the cov@print-firm macro if it is.

G. Branden Robinson <gbranden>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-07-17 gbranden StatusIn Progress => Fixed
        Open/ClosedOpen => Closed
        Planned ReleaseNone => 1.23.0
    2021-07-16 gbranden Severity2 - Minor => 3 - Normal
    2021-07-16 gbranden Summary[mm] throws warning if cover sheet used with no firm defined => [mm] aligns date wrong if ms cover sheet used with no firm defined
    2021-07-16 gbranden Item GroupWarning/Suspicious behaviour => Incorrect behaviour

    Back to the top


    Powered by Savane 3.7