bugmake - Bugs: bug #60659, Incorrect 2nd expansion of $$<...

 
 

bug #60659: Incorrect 2nd expansion of $$< inside a function in the prerequisite list.

Submitter:  Dmitry Goncharov <dgoncharov>
Submitted:  Sun 23 May 2021 02:26:36 PM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  4.4 Operating System:  Any
Fixed Release:  4.4 Triage Status:  Small Effort
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 06 Sep 2021 03:07:28 AM UTC, comment #5: 

Thanks, pushed to Git.

Paul D. Smith <psmith>
Group administrator
Sun 30 May 2021 03:06:22 PM UTC, comment #4: 

Sorry, I messed up.  You should definitely use '-u' when creating diffs... I meant, please do not use '-b' when creating diffs!

That was dumb.  Sorry :(.

Paul D. Smith <psmith>
Group administrator
Sun 30 May 2021 12:02:21 AM UTC, comment #3: 

Sure, will do.
Thanks for review.

Dmitry Goncharov <dgoncharov>
Sat 29 May 2021 11:09:58 PM UTC, comment #2: 

Thanks I've applied this.

Just a note when generating diffs for patches please don't add the '-u' option to 'git diff' otherwise the patches won't apply cleanly if you've made whitespace changes.

Cheers!

Paul D. Smith <psmith>
Group administrator
Sun 23 May 2021 02:38:21 PM UTC, comment #1: 

Attached tests of explicit and implicit rules and a fix.

Dmitry Goncharov <dgoncharov>
Sun 23 May 2021 02:26:36 PM UTC, original submission:  

.SECONDEXPANSION:
hello.x: world.z
hello.x: $$(info <=$$<) ;

Expected output of info is
<=world.z

Actual output of info is
<=

$(info) is used in this example. Other functions cause the same effect.

Dmitry Goncharov <dgoncharov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #51464:  sv60659_fix.diff added by dgoncharov (527B - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by dgoncharov (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-09-06 psmith StatusNone Fixed
        Assigned toNone psmith
        Open/ClosedOpen Closed
        Operating SystemNone Any
        Fixed ReleaseNone 4.4
        Triage StatusNone Small Effort
    2021-05-23 dgoncharov Attached File- Added sv60659_fix.diff, #51464
        Attached File- Added sv60659_test_implicit.diff, #51465
        Attached File- Added sv60659_test_explicit.diff, #51466

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code