bugGNU troff - Bugs: bug #60504, [PATCH] document .PF macro in...

 
 

bug #60504: [PATCH] document .PF macro in pic(1) and add it to -mpic

Submitted by:  Dave <barx>
Submitted on:  Mon 03 May 2021 08:05:53 AM UTC  
 
Category:  Preprocessor pic Severity:  3 - Normal
Item Group:  Documentation Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Planned Release:  None

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 01 Jun 2021 09:06:29 AM UTC, comment #2: 

I've updated the patch with one additional change.  It turns out pic itself didn't support .PF as fully as it could.

Part of pic's output includes empty definitions of .PS and .PE if they're not already defined.  This can be seen by giving it empty input:

$ pic < /dev/null
.do if !dPS .ds PS
.do if !dPE .ds PE
.lf 1 -
$

The updated patch now adds a dummy .PF to this output.

This will ameliorate the problem in the macro packages (listed in comment #1) that include a .PE but no .PF definition.

(file #51504)

Dave <barx>
Project Member
Sat 08 May 2021 04:11:37 PM UTC, comment #1: 

(The following bugs address the .PF omission in other macro packages that already support .PS and .PE:

-man and -mdoc appear to lack support for any of the pic macros.

-mm supports .PS and .PE, but it's not clear whether or how it should support pic's .PF, as -mm already uses .PF as a page-footer macro.)

Dave <barx>
Project Member
Mon 03 May 2021 08:05:53 AM UTC, original submission:  

(This bug was unearthed while poking into bug #60479.)

GNU pic recognizes two possible endings of a pic block: .PE or .PF.  This fact is documented in doc/pic.ms but not in the pic man page (src/preproc/pic/pic.1.man).

The man page and pic.ms both mention that the user can use -mpic to get a minimal implementation of the .PS and .PE macros.  This small macro file (tmac/pic.tmac), however, also does not include a .PF definition.

The attached patch remedies both of these oversights.  It also corrects pic.ms (to note that pic passes through .PF in addition to .PE, and to remove one unmatched closing parenthesis) and updates it (to account for the above change to pic.tmac).

Dave <barx>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #51504:  pic.patch added by barx (3KiB - text/x-patch - updated patch, per comment #2)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by barx (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-06-01 barx Attached File#51374 => Removed
    2021-06-01 barx Attached File- => Added pic.patch, #51504
    2021-05-03 barx Attached File- => Added pic.patch, #51374

    Back to the top


    Powered by Savane 3.6