bugGNU troff - Bugs: bug #60397, [mm] define string "RE"...

 
 

bug #60397: [mm] define string "RE" before it is used as the version

Submitted by:  Bjarni Ingi Gislason <bjarniig>
Submitted on:  Wed 14 Apr 2021 10:15:43 PM UTC  
 
Category:  Macro - mm Severity:  2 - Minor
Item Group:  Warning/Suspicious behaviour Status:  Fixed
Privacy:  Public Assigned to:  G. Branden Robinson <gbranden>
Open/Closed:  Closed Planned Release:  1.23.0

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 17 Jul 2021 01:00:36 AM UTC, comment #4: 

commit 34dc831a766c0b6eeb89a1a0b9ed93fa0efe33f1
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Jul 17 08:48:51 2021 +1000

    [mm]: Fix Savannah #60397.

    * contrib/mm/m.tmac: Stop emitting debugging diagnostic using undefined
      string.  Problem exposed by commit
      d6d98d2b3e0ad070037073bb288bbaee3fc04cf0, 8 December 2013.

    Fixes <https://savannah.gnu.org/bugs/?60397>.

G. Branden Robinson <gbranden>
Project AdministratorIn charge of this item.
Fri 16 Jul 2021 10:51:15 PM UTC, comment #3: 

comment #2:

> Perhaps it would be better just to drop this chunk of debugging output altogether.


And so that's what I am to do.

G. Branden Robinson <gbranden>
Project AdministratorIn charge of this item.
Sun 30 May 2021 03:29:22 PM UTC, comment #2: 

I'm not crazy about this patch because it doesn't impart any further information.  Theoretically, since mm is in contrib, it could have its own versioning scheme (as mom does, and as at least some of Bernd's stuff used to).  But, we haven't heard from  Jörgen Hägg on the groff list in many years so it's tough to make a case for it having independent versioning.

Perhaps it would be better just to drop this chunk of debugging output altogether.

G. Branden Robinson <gbranden>
Project AdministratorIn charge of this item.
Sun 30 May 2021 08:54:54 AM UTC, comment #1: 

I just stumbled across this myself.

original submission:

> $ echo | groff -ww -Tascii -rD1 -mm -z
> Groff mm, version troff: /usr/share/groff/1.22.4/tmac/m.tmac:364: warning: macro 'RE' not defined
> .

>
> Problem appears to date back to:
>

> commit d6d98d2b3e0ad070037073bb288bbaee3fc04cf0
> Author:     Eric S. Raymond <esr@thyrsus.com>
> AuthorDate: Sun Dec 8 12:51:42 2013 -0500
> Commit:     Eric S. Raymond <esr@thyrsus.com>
> CommitDate: Sun Dec 8 12:51:42 2013 -0500
>
>     First git commit.  Remove obsolete $Id$ and $Revision$ cookies.
>
> diff --git a/contrib/mm/m.tmac b/contrib/mm/m.tmac
> index 2a33c77b..ee5f908c 100644
> --- a/contrib/mm/m.tmac
> +++ b/contrib/mm/m.tmac
> @@ -1,10 +1,3 @@
> -.\"
> -.de @revision
> -.ds RE \\$2
> -..
> -.\"
> -.\" $Id$
> -.@revision $Revision$
>  .ig
>
>  Copyright (C) 1991-2006, 2009-2011

G. Branden Robinson <gbranden>
Project AdministratorIn charge of this item.
Wed 14 Apr 2021 10:15:43 PM UTC, original submission:  

From db0cc75902b8a5454d2be2ee3956f67063ee4dbb Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Wed, 14 Apr 2021 22:04:50 +0000
Subject: [PATCH] contrib/mm/m.tmac: define string "RE" before it is used as
 the version

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 contrib/mm/m.tmac | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/contrib/mm/m.tmac b/contrib/mm/m.tmac
index 161881d6..832ce964 100644
--- a/contrib/mm/m.tmac
+++ b/contrib/mm/m.tmac
@@ -364,7 +364,10 @@ Index array!index
 .ie d @country .mso mm/\*[@country]_locale
 .el .mso mm/locale
 .\"---------------------------------------------
-.if \n[D] .tm Groff mm, version \*[RE].
+.if \n[D] \{\
+.  ds RE \n[.x].\n[.y].\n[.Y]
+.  tm Groff mm, version \*[RE].
+.\}
 .\" ####### module init ######
 .\" reset all things
 .de init@reset
--
2.30.2

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-07-17 gbranden StatusIn Progress => Fixed
        Open/ClosedOpen => Closed
        Planned ReleaseNone => 1.23.0
    2021-07-16 gbranden StatusConfirmed => In Progress
        Assigned toNone => gbranden
    2021-05-30 gbranden StatusNone => Confirmed
        Summary[PATCH] contrib/mm/m.tmac: define string "RE" before it is used as the version => [mm] define string "RE" before it is used as the version
    2021-05-30 gbranden Severity3 - Normal => 2 - Minor

    Back to the top


    Powered by Savane 3.7