bugGNU roff - Bugs: bug #59268, [PATCH] tmac.am: non-portable...

 
 

bug #59268: [PATCH] tmac.am: non-portable $< syntax

Submitter:  Ingo Schwarze <schwarze>
Submitted:  Wed 14 Oct 2020 11:56:23 AM UTC
   
 
Category:  Macro man Severity:  3 - Normal
Item Group:  Build/Installation Status:  Fixed
Privacy:  Public Assigned to:  schwarze
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 05 Feb 2023 07:28:24 AM UTC, comment #3: 


commit 997b6b3c4582cc2897a1a79fb03dd7d2b88909cb
Author:     Ingo Schwarze <schwarze@openbsd.org>
AuthorDate: Wed Oct 14 13:52:29 2020 +0200
Commit:     Ingo Schwarze <schwarze@openbsd.org>
CommitDate: Wed Oct 14 15:50:47 2020 +0200

    tmac.am: do not use $< in a non-portable way

    fixes https://savannah.gnu.org/bugs/?59268
    OK gbranden@


G. Branden Robinson <gbranden>
Group administrator
Wed 14 Oct 2020 01:53:20 PM UTC, comment #2: 

Fixed in 997b6b3c4582cc2897a1a79fb03dd7d2b88909cb.

Ingo Schwarze <schwarze>
Group Member
Wed 14 Oct 2020 12:17:27 PM UTC, comment #1: 

Yes, that's a +1 from me.  I know POSIX shell much better than I know POSIX make.  Thanks!

G. Branden Robinson <gbranden>
Group administrator
Wed 14 Oct 2020 11:56:23 AM UTC, original submission:  

Groff no longer builds with POSIX make(1):

$ make
make  all-am
Using $< in a non-suffix rule context is a GNUmake idiom (Makefile:12441)
* Error 2 in /co/groff/build (Makefile:5317 'all')

This was broken in:
commit 31536c517dfe49b4e4a715a732f76b701531e90a
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Wed Aug 12 00:02:51 2020 +1000

The attached patch fixes the error.

Ingo Schwarze <schwarze>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #49978:  tmac.am.patch added by schwarze (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by schwarze (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-10-14 schwarze StatusNone Fixed
        Open/ClosedOpen Closed
    2020-10-14 schwarze Planned ReleaseNone 1.23.0
    2020-10-14 schwarze Attached File- Added tmac.am.patch, #49978

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code