bugGNU nano - Bugs: bug #58980, typing an unbound key cancels a...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #58980: typing an unbound key cancels a shift-selected region

Submitter:  Benno Schulenberg <bens>
Submitted:  Wed 19 Aug 2020 05:59:56 AM UTC
   
 
Severity:  2 - Minor Status:  Fixed
Assigned to:  bens Open/Closed:  Closed

Wed 19 Aug 2020 06:40:16 AM UTC, comment #2: 

Fixed in git, commit 51f27d3f, by deselecting a shift-marked region only when a non-shortcut key actually enters something into the buffer.

Benno Schulenberg <bens>
Group administrator
Wed 19 Aug 2020 06:22:00 AM UTC, comment #1: 

Bug exists since version 4.9.  The offending commit is 0ed62e84: "weld two fragments together, twice, by eliding an unneeded 'if'".

Ah, yes, that change made the deselecting fragment run also for unbound keys.  :|

Benno Schulenberg <bens>
Group administrator
Wed 19 Aug 2020 05:59:56 AM UTC, original submission:  

To reproduce, run 'src/nano --ignore THANKS',
then type: <Ctrl+Shift+Down> <Ctrl+Shift+Down>
See that a large piece of text is selected.
Now type: <Alt+PageUp>
Nano says: "There are no anchors", but the region stays selected.
Now type: <Alt+Home>
Nano says: "Unbound key", and the region is deselected.  This is unexpected and unneeded and inconsistent.

Now type <Ctrl+Shift+Down> down again, followed by: ^W Smurf <Enter>.  Nano says: ""Smurf" not found", and the region stays selected, which is cool.

Expected behavior: whenever it is not necessary to cancel a shift-selected region, it should remain selected.

Benno Schulenberg <bens>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-08-25 bens Open/ClosedOpen Closed
    2020-08-19 bens StatusIn Progress Fixed
    2020-08-19 bens StatusNone In Progress

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code