bugGNU nano - Bugs: bug #58414, nano crashes when window is...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #58414: nano crashes when window is resized during lock-file prompt

Submitter:  Benno Schulenberg <bens>
Submitted:  Wed 20 May 2020 05:15:29 PM UTC
   
 
Severity:  4 - Important Status:  Fixed
Assigned to:  bens Open/Closed:  Closed

Sun 24 May 2020 08:11:53 AM UTC, comment #5: 

Released in version 4.9.3.

Benno Schulenberg <bens>
Group administrator
Thu 21 May 2020 07:57:56 AM UTC, comment #4: 

Fixed in git, commit c9482bcd.

(The beeping issue has been reported in bug #58422.)

Benno Schulenberg <bens>
Group administrator
Wed 20 May 2020 05:58:04 PM UTC, comment #3: 

It's not just the title bar that gets drawn, but also the edit window.  Attached is a first patch that avoids the crash.

(The beep happens during resizing at every yes-no prompt.  I'll report that as a separate bug tomorrow.)

(file #49134)

Benno Schulenberg <bens>
Group administrator
Wed 20 May 2020 05:44:57 PM UTC, comment #2: 

The problem is, of course, that when the terminal is resized, that then the entire screen is reinitialized AND redrawn, and the redrawing draws also the title bar, and the title bar expects to have an open file to refer to.  :|

(The beeping since version 4.8 is caused by commit 12cf1c99: "beep when invalid key is pressed at yesno prompt or in linter menu".)

Benno Schulenberg <bens>
Group administrator
Wed 20 May 2020 05:27:47 PM UTC, comment #1: 

The offending commit appears to be b63c90bf: "do not open an empty buffer when respecting the first lock file".

Benno Schulenberg <bens>
Group administrator
Wed 20 May 2020 05:15:29 PM UTC, original submission:  

(Original report by Liu Hao in https://lists.gnu.org/archive/html/nano-devel/2020-05/msg00045.html.)

To reproduce, run:

nano --ignore --lock --suspend  README

Type ^Z.  Then open the file again with the same command:

nano --ignore --lock --suspend  README

At the "File README is being edited..." prompt, resize the window.

Result: "Sorry! Nano crashed!  Code: 11.  Please report a bug."

Bug exists since version 4.9.  It worked fine in version 4.7 and before.  Version 4.8 does not crash, but beeps on every resizing step.

Benno Schulenberg <bens>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #49134:  avoid-crash.diff added by bens (708B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-05-24 bens Open/ClosedOpen Closed
    2020-05-21 bens StatusIn Progress Fixed
    2020-05-20 bens Attached File- Added avoid-crash.diff, #49134
    2020-05-20 bens Severity5 - Blocker 4 - Important
        StatusNone In Progress

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code