bugGNU roff - Bugs: bug #58018, [PATCH] doc/pic.ms: Remove...

 
 

bug #58018: [PATCH] doc/pic.ms: Remove trailing spaces; correct '\"' inside quotes

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Sat 21 Mar 2020 10:57:21 PM UTC
   
 
Category:  Preprocessor pic Severity:  3 - Normal
Item Group:  Documentation Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 11 Aug 2021 09:10:25 PM UTC, comment #2: 


commit 22c12b95dd815b7b9863cc545a24a41e8a8f1083
Author: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date:   Sat Mar 21 22:34:55 2020 +0000

    doc/pic.ms: Fix damaged figure captions.

    '\"' is not how you escape a double quote in macro arguments; change it
    to one of at least two correct spellings, '""'.  Fixes damaged captions
    to Figures 3-5, 3-6, and 4-2.

    Also drop useless spaces from attribute grammar.

    Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>

    Fixes <https://savannah.gnu.org/bugs/?58018>.

    [Commit message rewritten by GBR.]


G. Branden Robinson <gbranden>
Group administrator
Wed 11 Aug 2021 01:45:42 PM UTC, comment #1: 

I'm dropping one of the hunks, quoted below, because it has no visible effect on output; the escape sequences (and \~ should always be considered over '\ ') are therefore impossible to motivate.  (The third hunk doesn't visibly affect output either, but the trailing spaces are similarly impossible to motivate.)

That first hunk was a very good catch, though.


@@ -1165,9 +1165,9 @@ define compass { [
         dot(ME.e);  "\fB .e\fP"  at ME .e ljust
         dot(ME.se); "\fB .se\fP" at ME .se below
         dot(ME.s);  "\fB.s\fP"   at ME .s below
-        dot(ME.sw); "\fB.sw \fP" at ME .sw below
-        dot(ME.w);  "\fB.w \fP"  at ME .w rjust
-        dot(ME.nw); "\fB.nw \fP" at ME .nw above
+        dot(ME.sw); "\fB.sw\ \fP" at ME .sw below
+        dot(ME.w);  "\fB.w\ \fP"  at ME .w rjust
+        dot(ME.nw); "\fB.nw\ \fP" at ME .nw above


G. Branden Robinson <gbranden>
Group administrator
Sat 21 Mar 2020 10:57:21 PM UTC, original submission:  

From 6f169495075d76419a9fb91b7e4d6ad1c7501eca Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Sat, 21 Mar 2020 22:34:55 +0000
Subject: [PATCH] doc/pic.ms: Remove trailing spaces; correct '\"'
 inside quotes

1) Change '\"' in a quoted argument to the correct '""'

2) Remove a space character at the end of a string (line).

3) Change a space character at the end of a string to '\ ',
to keep it there.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 doc/pic.ms | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/doc/pic.ms b/doc/pic.ms
index b7dfe32f..a4633e8c 100644
--- a/doc/pic.ms
+++ b/doc/pic.ms
@@ -329,7 +329,7 @@ would have been joined to the top of the arc, like this:
 .PS
 arc; move; "arc";
 .PE
-.CE "5: Result of \fBarc; move; \"arc\"\fP"
+.CE "5: Result of \fBarc; move; ""arc""\fP"
 .PP
 This is because drawing an arc changes the default direction to the
 one its exit end points at.
@@ -338,7 +338,7 @@ To reinforce this point, consider:
 .PS
 arc cw; move; "arc";
 .PE
-.CE "6: Result of \fBarc cw; move; \"arc\"\fP"
+.CE "6: Result of \fBarc cw; move; ""arc""\fP"
 .PP
 All we've done differently here is specify \[lq]cw\[rq] for a clockwise arc
 (\[lq]ccw\[rq] specifies counter-clockwise direction).
@@ -442,7 +442,7 @@ modifier:
 .PS
 box width 3 "this text is far too long for a default box"
 .PE
-.CE "2: Result of \fBbox width 3 \"text far too long\"\fP"
+.CE "2: Result of \fBbox width 3 ""text far too long""\fP"
 .PP
 This modifier takes a dimension in inches.
 There is also a \[lq]height\[rq] modifier that changes a box's height.
@@ -1165,9 +1165,9 @@ define compass { [
         dot(ME.e);  "\fB .e\fP"  at ME .e ljust
         dot(ME.se); "\fB .se\fP" at ME .se below
         dot(ME.s);  "\fB.s\fP"   at ME .s below
-        dot(ME.sw); "\fB.sw \fP" at ME .sw below
-        dot(ME.w);  "\fB.w \fP"  at ME .w rjust
-        dot(ME.nw); "\fB.nw \fP" at ME .nw above
+        dot(ME.sw); "\fB.sw\ \fP" at ME .sw below
+        dot(ME.w);  "\fB.w\ \fP"  at ME .w rjust
+        dot(ME.nw); "\fB.nw\ \fP" at ME .nw above
 ] }
 compass(box wid 1.5 ht 1);
 move right from last [] .e;
@@ -2878,14 +2878,14 @@ direction on the block's bounding box.
 .DS
 .CW
 <attribute> ::=
-  h[eigh]t <expr>       \fR# set height of closed figure \fP
-  wid[th] <expr>        \fR# set width of closed figure \fP
-  rad[ius] <expr>       \fR# set radius of circle/arc \fP
-  diam[eter] <expr>     \fR# set diameter of circle/arc \fP
-  up [<expr>]           \fR# move up \fP
-  down [<expr>]         \fR# move down \fP
-  left [<expr>]         \fR# move left \fP
-  right [<expr>]        \fR# move right \fP
+  h[eigh]t <expr>       \fR# set height of closed figure\fP
+  wid[th] <expr>        \fR# set width of closed figure\fP
+  rad[ius] <expr>       \fR# set radius of circle/arc\fP
+  diam[eter] <expr>     \fR# set diameter of circle/arc\fP
+  up [<expr>]           \fR# move up\fP
+  down [<expr>]         \fR# move down\fP
+  left [<expr>]         \fR# move left\fP
+  right [<expr>]        \fR# move right\fP
   from <position>       \fR# set from position of open figure\fP
   to <position>         \fR# set to position of open figure\fP
   at <position>         \fR# set center of open figure\fP
--
2.25.1


Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-08-11 gbranden StatusIn Progress Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.23.0
    2021-08-11 gbranden StatusNone In Progress
        Assigned toNone gbranden
    2021-06-07 barx Carbon-CopyRemoved 93119 -
    2021-06-07 barx CategoryNone Preprocessor pic
    2020-10-13 barx Carbon-CopyRemoved 93119 -
    2020-10-13 barx SummaryPATCH] doc/pic.ms: Remove trailing spaces; correct '\&quot;' inside quotes [PATCH] doc/pic.ms: Remove trailing spaces; correct '\"' inside quotes
    2020-03-21 bjarniig Attached File- Added 0001-Subject-doc-pic.ms-Remove-trailing-spaces-correct-insi.txt, #48639

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code