bugGNU nano - Bugs: bug #57994, in the Korean locale, the title...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #57994: in the Korean locale, the title bar can get pushed offscreen

Submitter:  Benno Schulenberg <bens>
Submitted:  Sun 15 Mar 2020 04:24:39 PM UTC
   
 
Severity:  4 - Important Status:  Fixed
Assigned to:  bens Open/Closed:  Closed

Jump to the original submission

Wed 25 Mar 2020 10:05:24 AM UTC, comment #7: 

Fixed in version 4.9.

Benno Schulenberg <bens>
Group administrator
Sun 22 Mar 2020 06:55:50 PM UTC, comment #6: 

[The inaccuracy in the man page has been reported in https://lists.gnu.org/archive/html/bug-ncurses/2020-03/msg00021.html.  As a result, Thomas has made several adjustments to the ncurses docs.]

Benno Schulenberg <bens>
Group administrator
Mon 16 Mar 2020 08:52:48 AM UTC, comment #5: 

Fixed in git, commit 56308b32.

(The offending commit did not directly increase the number of bytes written, but the number of usable columns.  It should have increased this number only for the last item of each help item.)

Benno Schulenberg <bens>
Group administrator
Mon 16 Mar 2020 08:26:28 AM UTC, comment #4: 

No.  The manual page of waddnstr() may say that n is the number of characters, but this is not true: it is the number of bytes.

The offending commit is in fact e806ab84, a patch by myself from fourteen years ago: it increased the number of bytes written for each help item, whereas it should have increased it only for the last two.

Benno Schulenberg <bens>
Group administrator
Sun 15 Mar 2020 07:30:04 PM UTC, comment #3: 

The problem is located in post_one_key().  The n argument in the waddnstr() function should be the number of characters to print, not the number of bytes.

Problem exists since 2004, commit 1903ace2.  That means: probably since version 1.3.6.

Benno Schulenberg <bens>
Group administrator
Sun 15 Mar 2020 04:44:19 PM UTC, comment #2: 

Bug exists since at least version 2.0.6.  (When making sure that all shown strings in the bottom lines are translated.)

Benno Schulenberg <bens>
Group administrator
Sun 15 Mar 2020 04:34:06 PM UTC, comment #1: 

The problem is much worse in the Korean locale.  There the problem is present even when the terminal is the common 80 columns wide.

In an 80-column terminal, run:

LANGUAGE=ko src/nano --ignore


See how there is no title bar and there is a lone character (로) on the bottom row:

^G 도움말 보기^O 기록 내보내^W 현재 위치 ^K 텍스트 잘라^J 정렬   ^C 커서 위치
^X 나가기    ^R 파일 읽기 ^\ 바꾸기    ^U 텍스트 붙여^T 해당 철자로^_ 지정 행으

(This paste does not exactly represent my screen.  On my screen, all keystrokes (except ^G and ^X) are misaligned.)

Benno Schulenberg <bens>
Group administrator
Sun 15 Mar 2020 04:24:39 PM UTC, original submission:  

To reproduce, make your terminal 41 columns narrow, and run:

LANGUAGE=ja src/nano --ignore

See that there is no title bar, and that the help lines are one row up from where they normally are.

The problem is that the description of ^U (貼り付け) is four characters long, and there is room for only three.  The fourth character gets pushed to the next row, causing the screen to scroll one row, pushing the title bar offscreen.

(The description for ^K (切り取り) is also four characters long, but its final character, that gets written to the second helpline, then immediately gets overwritten by the "^X" and the rest.)

The problem also occurs when the terminal is 20 or 13 columns narrow.

Benno Schulenberg <bens>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-03-25 bens Open/ClosedOpen Closed
    2020-03-16 bens StatusIn Progress Fixed
        Summaryin the Korean locale, the title bar is pushed offscreen in the Korean locale, the title bar can get pushed offscreen
    2020-03-15 bens StatusNone In Progress
        Assigned toNone bens
    2020-03-15 bens Summaryin the Korean locale, the title bar is not shown in the Korean locale, the title bar is pushed offscreen
    2020-03-15 bens Severity3 - Normal 4 - Important
        Summaryin the Japanese locale, the title bar can disappear in the Korean locale, the title bar is not shown

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code