bugGNU nano - Bugs: bug #57929, in current git, nano aborts when...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #57929: in current git, nano aborts when trying to filter an empty region

Submitter:  Benno Schulenberg <bens>
Submitted:  Sun 01 Mar 2020 08:48:21 AM UTC
   
 
Severity:  4 - Important Status:  Fixed
Assigned to:  bens Open/Closed:  Closed

Sun 01 Mar 2020 02:07:41 PM UTC, comment #3: 

Well, in fact the "<Ctrl+Shift+Down> ^R ^X |grep eeeee <Enter> M-U M-E" crashing problem is excatly the same as bug #57915, and is fixed by commit 0568f7a2.

Thus, commit 8848ac5a just undoes the blocking (by commit b15c5a7e) of the filtering of an empty region, AND avoids creating a new possibility for a crash due to u->cutbuffer being NULL when the result of a filtering is empty.

So, this bug can be closed as it has not been released.

(The minor issue that the buffer is marked as modified even though the filtering command inserted nothing, I will leave unaddressed.)

Benno Schulenberg <bens>
Group administrator
Sun 01 Mar 2020 12:05:23 PM UTC, comment #2: 

Fixed in git, commit 8848ac5a.

Benno Schulenberg <bens>
Group administrator
Sun 01 Mar 2020 10:15:41 AM UTC, comment #1: 

Older versions of nano would crash when trying the given recipe.  (The problem, however, is not the empty region -- when the region is empty, apparently the whole buffer gets filtered -- but the empty filtering result, the "pasting of nothing".)

To reproduce, run 'src/nano --ignore +9 README'.
Then type: <Ctrl+Shift+Down> ^R ^X |grep eeeee <Enter> M-U M-E.
Result: nano crashes.

(This basically the same bug as bug #57915, but then for pasting instead of inserting.)

Benno Schulenberg <bens>
Group administrator
Sun 01 Mar 2020 08:48:21 AM UTC, original submission:  

To reproduce, run 'src/nano --ignore +9 README'.
Then type: ^6 ^R ^X |grep foo <Enter>

Result: nano aborts with "Adding empty undo item -- please report a bug".

Benno Schulenberg <bens>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-03-01 bens Open/ClosedOpen Closed
        Summarynano crashes when redoing an empty filter result in current git, nano aborts when trying to filter an empty region
    2020-03-01 bens StatusIn progress Fixed
    2020-03-01 bens Severity5 - Blocker 4 - Important
        StatusNone In progress
        Summaryin current git, nano aborts when trying to filter an empty region nano crashes when redoing an empty filter result
    2020-03-01 bens Summarynano aborts when trying to filter an empty region in current git, nano aborts when trying to filter an empty region

    Back to the top

    Powered by Savane 3.14-9aa3.
    Corresponding source code