bugGNU nano - Bugs: bug #57916, in current git, undoing a line...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #57916: in current git, undoing a line join kills the first of the two lines

Submitter:  Benno Schulenberg <bens>
Submitted:  Fri 28 Feb 2020 12:36:14 PM UTC
   
 
Severity:  5 - Blocker Status:  Fixed
Assigned to:  bens Open/Closed:  Closed

Fri 28 Feb 2020 04:19:45 PM UTC, comment #3: 

Fixed in git, commit 7d0b7e47.

And closing because unreleased.

Benno Schulenberg <bens>
Group administrator
Fri 28 Feb 2020 02:44:53 PM UTC, comment #2: 

The offending commit is 7cf08b93: "don't bother reallocating the line data when undoing a line join".

Benno Schulenberg <bens>
Group administrator
Fri 28 Feb 2020 02:34:37 PM UTC, comment #1: 

To reproduce, run:

src/nano --ignore +5 README

Then type: <Backspace> M-U.  See that the line with "Overview" has disappeared.  :|

Bug exists only in git.  Version 4.8 and earlier are fine.

Benno Schulenberg <bens>
Group administrator
Fri 28 Feb 2020 12:36:14 PM UTC, original submission:  

I had made some edits in src/text.c, then moved to the start of the do_redo() function to add a declaration.  I started adding a line, then reconsidered, wanted to add the line further up, I hit some wrong key, a line disappeared, so I hit M-U, but the line did not come back, and a second M-U started undoing the edits I had made further down.  I hit ^S ^X, and did a 'git diff'.  Indeed, a declaration line had disappeared -- an M-U had not brough it back.  :|

Benno Schulenberg <bens>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-02-28 bens StatusIn progress Fixed
        Open/ClosedOpen Closed
    2020-02-28 bens StatusNone In progress
    2020-02-28 bens Severity3 - Normal 5 - Blocker
        Assigned toNone bens
        Summarythere is an undo bug that I cannot reproduce in current git, undoing a line join kills the first of the two lines

    Back to the top

    Powered by Savane 3.14-5139.
    Corresponding source code