bugGNU troff - Bugs: bug #57546, [PATCH] make \[dd] transparent for...

 
 

bug #57546: [PATCH] make \[dd] transparent for end-of-sentence detection

Submitted by:  Dave <barx>
Submitted on:  Mon 06 Jan 2020 10:22:45 PM UTC  
 
Category:  Core Severity:  3 - Normal
Item Group:  Warning/Suspicious behaviour Status:  Fixed
Privacy:  Public Assigned to:  G. Branden Robinson <gbranden>
Open/Closed:  Closed Planned Release:  1.22.5

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Fri 17 Jan 2020 03:25:08 PM UTC, comment #6: 

Fixed in fe573546753df07e94d77303d967899cc61d4690.

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Fri 17 Jan 2020 08:24:38 AM UTC, comment #5: 

comment #3:

> In any case, as groff_char(7) currently stands, the sic's meaning is
> unclear, but this is probably an issue for a different bug report.


And that bug report is bug #57618.

Dave <barx>
Tue 07 Jan 2020 05:25:38 PM UTC, comment #4: 

The [sic] shall indeed be a hint for the misspelling.  Being not a native English speaker I'm glad if someone is going to improve that.

Note that even the opening and closing quote characters are sometimes used as closing and opening quotes depending on the language (or region).

Werner LEMBERG <wl>
Project Administrator
Tue 07 Jan 2020 05:09:26 PM UTC, comment #3: 

comment #2:

> in Germany and Austria those two characters are opening delimiters.


Ah, OK.  Is that why the "[sic]" appears after the words "left guillemet" and "right guillemet" in man/groff_char.7.man?  I had thought it had to do with the PostScript character misspelling the term as "guillemot" (although the "[sic]" is in a weird place if so), but maybe it's pointing out that the so-called left guillemet is used on the right-hand side in some languages, and vice versa.  In any case, as groff_char(7) currently stands, the sic's meaning is unclear, but this is probably an issue for a different bug report.

Dave <barx>
Tue 07 Jan 2020 07:28:40 AM UTC, comment #2: 

Whether \[Fc] and \[fc] are used as closing delimiters is language or region dependent.  For example, in Germany and Austria those two characters are opening delimiters.  In Swiss German it is a closing delimiter (similar to France but without the small amount of whitespace before it).  In other words, for a single language (German) you have different usage depending on the region.  This is something groff doesn't support out of the box...

Werner LEMBERG <wl>
Project Administrator
Tue 07 Jan 2020 01:28:17 AM UTC, comment #1: 

Debatably, the characters \[Fc] and \[fc] could have cflags 32 set by default as well.

Arguing against: groff's defaults are tailored to English, and these characters are not used in standard English.

Arguing for: these characters are closing quotation marks, and ought to be treated the same way as the rest of groff's closing-quotation-mark characters.

Dave <barx>
Mon 06 Jan 2020 10:22:45 PM UTC, original submission:  

The characters \[dd] and \[dg] have nearly identical meanings, so should be treated identically in text processing.  groff, however, gives \[dg] but not \[dd] a cflags value of 32.  It is probably better to address this by adding \[dd] to this category rather than removing \[dg].

Commit 54405b9a made a similar change, adding character (\[cq]) to the "transparent" set.  Using this commit as a template, I crafted the attached patch to add \[dd].  It changes all the same files as 54405b9a except ChangeLog, which will have to be done by whoever applies the patch anyway.

Dave <barx>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #48173:  add_dd_char.patch added by barx (3KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Updated the item)
  • -email is unavailable- added by wl (Posted a comment)
  • -email is unavailable- added by barx (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-01-17 gbranden StatusConfirmed => Fixed
    2020-01-17 gbranden Open/ClosedOpen => Closed
        Planned ReleaseNone => 1.22.5
    2020-01-17 gbranden StatusNone => Confirmed
        Assigned toNone => gbranden
    2020-01-06 barx Attached File- => Added add_dd_char.patch, #48173

    Back to the top


    Powered by Savane 3.5