GNU Octave - Bugs: bug #57353, crash signal 11 when using patch()...
bug #57353: crash signal 11 when using patch() with large stl file
Submitter: | None | ||
Submitted: | Tue 03 Dec 2019 10:32:14 PM UTC | ||
Category: | Plotting | Severity: | 4 - Important |
Priority: | 5 - Normal | Item Group: | Segfault, Bus Error, etc. |
Status: | Fixed | Assigned to: | rik5 |
Originator Name: | Marcel Hell | Originator Email: | -email is unavailable- |
Open/Closed: | Closed | Release: | 5.1.0 |
Operating System: | GNU/Linux | Fixed Release: | None |
Planned Release: | None |
Discussion locked!
Jump to the original submission
Spam posted by _245194 | |
Fri 06 Dec 2019 08:27:36 PM UTC, comment #36: |
John W. Eaton <jwe> |
Fri 06 Dec 2019 07:20:22 PM UTC, comment #35: I made a few changes to wording and pushed Markus' comment here https://hg.savannah.gnu.org/hgweb/octave/rev/1e6389ae4060. |
Rik <rik5> |
Fri 06 Dec 2019 07:09:03 PM UTC, comment #34: Yes, I agree we need some explanation of the intent.
|
John W. Eaton <jwe> |
Fri 06 Dec 2019 06:35:14 PM UTC, comment #33: The attached patch adds a comment to motivate why that particular type is used.
|
Markus Mützel <mmuetzel> |
Fri 06 Dec 2019 03:52:11 PM UTC, comment #32: I think a comment above the declaration is probably required, just so it doesn't get undone at a later point in time. It isn't at all clear to me what "std::vector<std::vector<RowVector>>" is and why it would be required. |
Rik <rik5> |
Fri 06 Dec 2019 03:27:41 AM UTC, comment #31: Thanks for finding a fix for this problem.
|
John W. Eaton <jwe> |
Thu 05 Dec 2019 11:08:53 PM UTC, comment #30: Thank you all, now it worked!
|
Marcel Hell <marcel756> |
Thu 05 Dec 2019 09:57:03 PM UTC, comment #29: The error "Network is unreachable" is usually a temporary issue caused by too many requests. It usually clears up in 10-15 minutes. You might just try hg pull again. |
Rik <rik5> |
Thu 05 Dec 2019 09:45:34 PM UTC, comment #28: Hi Marcel,
|
Hg200 <hg200> |
Thu 05 Dec 2019 09:27:53 PM UTC, comment #27: hg200:
|
Marcel Hell <marcel756> |
Thu 05 Dec 2019 09:24:18 PM UTC, comment #26: unfortunately not:
|
Marcel Hell <marcel756> |
Thu 05 Dec 2019 08:58:59 PM UTC, comment #25: I'm not the original reporter, but I can verify that this now works for me.
|
Rik <rik5> |
Thu 05 Dec 2019 08:57:06 PM UTC, comment #24: Markus,
|
Hg200 <hg200> |
Thu 05 Dec 2019 08:24:37 PM UTC, comment #23: I pushed the following change to use "new" to allocate the memory dynamically:
|
Markus Mützel <mmuetzel> |
Thu 05 Dec 2019 08:20:30 PM UTC, comment #22: i have tweaked the MWE to create the "new" segfault (according to the gdb backtrace) on my laptop. please find attached test_patch_v2.m.
|
Hg200 <hg200> |
Thu 05 Dec 2019 07:22:32 PM UTC, comment #21: Sorry. Please ignore. 10 MiB not 10 GiB. |
Markus Mützel <mmuetzel> |
Thu 05 Dec 2019 07:18:25 PM UTC, comment #20: The size of a std::vector is implementation dependent. But most commonly, it is 24 bytes on 64bit systems. I.e. that call tries to allocate more than 10 GiB of memory. That might be the cause of the segfault.
|
Markus Mützel <mmuetzel> |
Thu 05 Dec 2019 05:32:37 PM UTC, comment #19: Here is my backtrace output. Some informations in advance:
|
Hg200 <hg200> |
Thu 05 Dec 2019 04:36:36 PM UTC, comment #18: Hi, here's the output:
|
Marcel Hell <marcel756> |
Thu 05 Dec 2019 03:44:44 PM UTC, comment #17: I guess it's time to try poking around with the debugger.
|
Rik <rik5> |
Thu 05 Dec 2019 03:36:58 PM UTC, comment #16: I guess: Two independent problems.
|
Hg200 <hg200> |
Thu 05 Dec 2019 09:19:10 AM UTC, comment #15: @Dmitry: yes it still crashes.
|
Marcel Hell <marcel756> |
Thu 05 Dec 2019 12:31:59 AM UTC, comment #14: Does it crash if you start octave as :
|
Dmitri A. Sergatskov <dasergatskov> |
Thu 05 Dec 2019 12:27:01 AM UTC, comment #13: That's odd. I think you will need to run octave under a debugger and obtain a backtrace to find out where the segfault is coming from.
|
Rik <rik5> |
Wed 04 Dec 2019 11:35:13 PM UTC, comment #12: now _octave_config_info_ ("hg_id") returns ans = 54767f6a93f5
|
Marcel Hell <marcel756> |
Wed 04 Dec 2019 11:25:00 PM UTC, comment #11: That explains it. The hg id of your build is for cset 27771. You need to be at cset 27773 in order to see the fix. Try
|
Rik <rik5> |
Wed 04 Dec 2019 11:15:30 PM UTC, comment #10: ans = cd566153edd6 |
Marcel Hell <marcel756> |
Wed 04 Dec 2019 10:19:38 PM UTC, comment #9: What does this return?
|
Rik <rik5> |
Wed 04 Dec 2019 10:17:37 PM UTC, comment #8: I downloaded and build octave from the Mercurial repo, and it shows as version 6.0.
|
Marcel Hell <marcel756> |
Wed 04 Dec 2019 08:05:01 PM UTC, comment #7: Fixed on the stable branch in this changeset: https://hg.savannah.gnu.org/hgweb/octave/rev/2d1af61d8f5e.
|
Rik <rik5> |
Wed 04 Dec 2019 07:50:50 PM UTC, comment #6: Yes, that was the problem. I found another instance of the same construct as well. Will have a fix shortly. |
Rik <rik5> |
Wed 04 Dec 2019 07:29:49 PM UTC, comment #5: Confirmed. I just tested the MWE on the development tip with a debug version of Octave and obtained the following backtrace.
|
Rik <rik5> |
Wed 04 Dec 2019 05:47:46 PM UTC, comment #4: I was able to reproduce and to simplify. MWE is attached.
|
Hg200 <hg200> |
Wed 04 Dec 2019 04:40:06 PM UTC, comment #3:
|
Marcel Hell <marcel756> |
Wed 04 Dec 2019 04:33:35 PM UTC, comment #2: I cannot upload the file, due to its size of 38m.
|
Marcel Hell <marcel756> |
Wed 04 Dec 2019 07:00:05 AM UTC, comment #1: To reproduce the issue, can you attach "upper.stl" to this item? |
Kai Torben Ohlhus <siko1056> |
Tue 03 Dec 2019 10:32:14 PM UTC, original submission:
Hello, I am trying to display a 24 MB stl file using stlread and then patch()
|
Anonymous |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 25 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2021-03-22 | rik5 | Discussion Lock | None | Locked | |
2020-12-16 | mmuetzel | Attached File | #50487 | Removed | |
2020-12-16 | ngaydem | Attached File | - | Added bao-duong-he-thong-pccc.jpg, #50487 | |
2019-12-06 | rik5 | Status | Ready For Test | Fixed | |
Open/Closed | Open | Closed | |||
2019-12-06 | mmuetzel | Attached File | - | Added bug57353_patch_face_normals_comment.patch, #48019 | |
Status | Fixed | Ready For Test | |||
Open/Closed | Closed | Open | |||
2019-12-05 | rik5 | Status | Ready For Test | Fixed | |
Open/Closed | Open | Closed | |||
2019-12-05 | mmuetzel | Status | Fixed | Ready For Test | |
Open/Closed | Closed | Open | |||
2019-12-05 | hg200 | Attached File | - | Added test_patch_v2.m, #48005 | |
2019-12-04 | rik5 | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2019-12-04 | rik5 | Severity | 3 - Normal | 4 - Important | |
Item Group | Unexpected Error or Warning | Segfault, Bus Error, etc. | |||
Status | Confirmed | In Progress | |||
Assigned to | None | rik5 | |||
Release | dev | 5.1.0 | |||
2019-12-04 | rik5 | Category | None | Plotting | |
Status | Need Info | Confirmed | |||
Release | 5.1.0 | dev | |||
2019-12-04 | hg200 | Carbon-Copy | - | Added hg200 | |
2019-12-04 | hg200 | Attached File | - | Added test_patch.m, #47997 |
Powered by Savane 3.13-d3ae.
Corresponding source code
Marcus, Rik, and Hg200, thanks for fixing this problem.