bugmake - Bugs: bug #57151, Fix WINDOWS32 MSVS build

 
 

bug #57151: Fix WINDOWS32 MSVS build

Submitted by:  Ben <bwijen>
Submitted on:  Sat 02 Nov 2019 09:28:10 AM UTC  
 
Severity:  3 - Normal Item Group:  Build/Install
Status:  Fixed Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Component Version:  4.3 Operating System:  MS Windows
Fixed Release:  4.3 Triage Status:  None

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 17 Dec 2019 08:33:18 PM UTC, comment #1: 

This needs to be Sleep(1000) since Windows Sleep() accepts arguments in milliseconds not seconds.

I guess I never tried to build GNU make in maintainer mode on Windows.  Thanks for the patches!

Paul D. Smith <psmith>
Project Administrator
Sat 02 Nov 2019 09:28:10 AM UTC, original submission:  

Running `bootstrap.bat` and `build_w32.bat` from tag `4.2.92` results in:
src/misc.c(421): warning C4013: 'sleep' undefined; assuming extern returning int

And eventually:

   Creating library .\WinRel\gnumake.lib and object .\WinRel\gnumake.exp
misc.obj : error LNK2019: unresolved external symbol sleep referenced in function spin
.\WinRel\gnumake.exe : fatal error LNK1120: 1 unresolved externals

The attached patches are:

  • Minor typo fix
  • Fix for this issue

Tested with MSVS2017 and MSVS2019

Ben <bwijen>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #47777:  0001-Fix-typo.patch added by bwijen (555B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by bwijen (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-12-17 psmith StatusNone => Fixed
        Open/ClosedOpen => Closed
        Fixed ReleaseNone => 4.3
    2019-11-02 bwijen Attached File- => Added 0001-Fix-typo.patch, #47777
        Attached File- => Added 0002-Fix-WINDOWS32-MSVS-build.patch, #47778

    Back to the top


    Powered by Savane 3.7