bugDDD - Bugs: bug #56719, When doing 'make', I got an error...

 
 

bug #56719: When doing 'make', I got an error of "friend declaration of 'string common_prefix(const string&, const string&, int)'"

Submitted by:  catherina <banality>
Submitted on:  Mon 05 Aug 2019 04:06:04 PM UTC  
 
Category:  Build Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Release:  3.3.12-rc1

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 02 Nov 2019 05:59:37 AM UTC, comment #1: 

Hi,
I hope you can give the patch I posted a try.

Craig Bumpstead <craigab69>
Mon 05 Aug 2019 04:06:04 PM UTC, original submission:  

My system is archlinux+dde

I typed "./configure && make", then
...
...
config.status: WARNING:  ddd/OldMakefile.in seems to ignore the --datarootdir setting
...
...
...
make[3]: Leaving directory '/home/banality/ddd-3.3.12/ddd'
./stringify < ddd.info.txt.gz > ddd.info.txt.gz.C~ && mv ddd.info.txt.gz.C~ ddd.info.txt.gz.C
g++ -DHAVE_CONFIG_H -I.  -I./..    -O2 -g -Wall -W -Wwrite-strings -trigraphs  -MT ddd.o -MD -MP -MF .deps/ddd.Tpo -c -o ddd.o ddd.C
In file included from ddd.h:31,
                 from ddd.C:134:
strclass.h:813:19: error: friend declaration of ‘string common_prefix(const string&, const string&, int)’ specifies default arguments and isn’t a definition [-fpermissive]
  813 |     friend string common_prefix(const string& x, const string& y,
      |                   ^~~~~~~~~~~~~
strclass.h:815:19: error: friend declaration of ‘string common_suffix(const string&, const string&, int)’ specifies default arguments and isn’t a definition [-fpermissive]
  815 |     friend string common_suffix(const string& x, const string& y,
      |                   ^~~~~~~~~~~~~
strclass.h:866:16: error: friend declaration of ‘int readline(std::istream&, string&, char, int)’ specifies default arguments and isn’t a definition [-fpermissive]
  866 |     friend int readline(std::istream& s, string& x,
      |                ^~~~~~~~
In file included from DataDisp.h:53,
                 from ddd.C:186:
Command.h: In member function ‘bool Command::operator==(const Command&) const’:
Command.h:172:6: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
  162 |      command == c.command
      |      ~~~~~~~~~~~~~~~~~~~~
  163 |      && origin == c.origin
      |      ~~~~~~~~~~~~~~~~~~~~~
  164 |      && callback == c.callback
      |      ~~~~~~~~~~~~~~~~~~~~~~~~~
  165 |      && extra_callback == c.extra_callback
      |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  166 |      && data == c.data
      |      ~~~~~~~~~~~~~~~~~
  167 |      && echo == c.echo
      |      ~~~~~~~~~~~~~~~~~
  168 |      && verbose == c.verbose
      |      ~~~~~~~~~~~~~~~~~~~~~~~
  169 |      && prompt == c.prompt
      |      ~~~~~~~~~~~~~~~~~~~~~
  170 |      && check == c.check
      |      ~~~~~~~~~~~~~~~~~~~
  171 |      && start_undo == c.start_undo
      |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  172 |      && priority == c.priority;
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from DataDisp.h:57,
                 from ddd.C:186:
GraphEdit.h: In member function ‘GraphEditPositionChangedInfo& GraphEditPositionChangedInfo::operator=(const GraphEditPositionChangedInfo&)’:
GraphEdit.h:181:24: warning: implicitly-declared ‘constexpr BoxPoint& BoxPoint::operator=(const BoxPoint&)’ is deprecated [-Wdeprecated-copy]
  181 |    old_position = info.old_position;
      |                        ^~~~~~~~~~~~
In file included from BoxSize.h:34,
                 from DataDisp.h:52,
                 from ddd.C:186:
BoxPoint.h:62:5: note: because ‘BoxPoint’ has user-provided ‘BoxPoint::BoxPoint(const BoxPoint&)’
   62 |     BoxPoint(const BoxPoint& p)
      |     ^~~~~~~~
In file included from DataDisp.h:57,
                 from ddd.C:186:
GraphEdit.h:182:24: warning: implicitly-declared ‘constexpr BoxPoint& BoxPoint::operator=(const BoxPoint&)’ is deprecated [-Wdeprecated-copy]
  182 |    new_position = info.new_position;
      |                        ^~~~~~~~~~~~
In file included from BoxSize.h:34,
                 from DataDisp.h:52,
                 from ddd.C:186:
BoxPoint.h:62:5: note: because ‘BoxPoint’ has user-provided ‘BoxPoint::BoxPoint(const BoxPoint&)’
   62 |     BoxPoint(const BoxPoint& p)
      |     ^~~~~~~~
In file included from Graph.h:32,
                 from DispGraph.h:38,
                 from ddd.C:189:
GraphGC.h: In member function ‘GraphGC& GraphGC::operator=(const GraphGC&)’:
GraphGC.h:163:33: warning: implicitly-declared ‘constexpr BoxPoint& BoxPoint::operator=(const BoxPoint&)’ is deprecated [-Wdeprecated-copy]
  163 |      offsetIfSelected       = g.offsetIfSelected;
      |                                 ^~~~~~~~~~~~~~~~
In file included from BoxSize.h:34,
                 from DataDisp.h:52,
                 from ddd.C:186:
BoxPoint.h:62:5: note: because ‘BoxPoint’ has user-provided ‘BoxPoint::BoxPoint(const BoxPoint&)’
   62 |     BoxPoint(const BoxPoint& p)
      |     ^~~~~~~~
In file included from DispGraph.h:41,
                 from ddd.C:189:
PosGraphN.h: In member function ‘virtual void PosGraphNode::moveTo(const BoxPoint&)’:
PosGraphN.h:64:13: warning: implicitly-declared ‘constexpr BoxPoint& BoxPoint::operator=(const BoxPoint&)’ is deprecated [-Wdeprecated-copy]
   64 |      _pos = newPos;
      |             ^~~~~~
In file included from BoxSize.h:34,
                 from DataDisp.h:52,
                 from ddd.C:186:
BoxPoint.h:62:5: note: because ‘BoxPoint’ has user-provided ‘BoxPoint::BoxPoint(const BoxPoint&)’
   62 |     BoxPoint(const BoxPoint& p)
      |     ^~~~~~~~
ddd.C: In function ‘ddd_exit_t pre_main_loop(int, char**)’:
ddd.C:2986:43: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
 2986 |     if ((!app_data.separate_source_window && have_source_window() ||
      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
ddd.C: In function ‘Boolean ddd_setup_done(XtPointer)’:
ddd.C:3961:24: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
 3961 |      app_data.annotate && running_shells() == 1)
      |      ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
ddd.C: In function ‘void update_options()’:
ddd.C:4248:29: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
 4248 |     !app_data.button_images && !app_data.button_captions);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
ddd.C:4290:6: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
 4289 |     source_view->set_disassemble(gdb->type() == GDB || gdb->type() == PYDB
      |                                                        ~~~~~~~~~~~~~~~~~~~
 4290 |      && app_data.disassemble);
      |      ^~~~~~~~~~~~~~~~~~~~~~~
In file included from ddd.C:203:
ddd.C: In function ‘void BlinkCB(XtPointer, XtIntervalId*)’:
ddd.C:5469:30: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 5469 |           XtPointer(int(!set)));
      |                              ^
TimeOut.h:55:37: note: in definition of macro ‘XtAppAddTimeOut’
   55 |     MyAppAddTimeOut((a), (i), (p), (c), (const char *)__FILE__, _LINE_)
      |                                     ^
ddd.C: In constructor ‘WhenReadyInfo::WhenReadyInfo(const MString&, XtCallbackProc, XtPointer, const XmPushButtonCallbackStruct&)’:
ddd.C:5825:33: warning: argument to ‘sizeof’ in ‘void* memcpy(void*, const void*, size_t)’ call is the same expression as the destination; did you mean to dereference it? [-Wsizeof-pointer-memaccess]
 5825 |      memcpy(cbs.event, c.event, sizeof(cbs.event));
      |                                 ^~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:2048: ddd.o] Error 1
make[2]: Leaving directory '/home/banality/ddd-3.3.12/ddd'
make[1]: *** [Makefile:1708: all] Error 2
make[1]: Leaving directory '/home/banality/ddd-3.3.12/ddd'
make: *** [Makefile:420: all-recursive] Error 1

catherina <banality>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #47759:  complete.patch added by craigab69 (3KiB - text/x-patch - Hi,)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by craigab69 (Updated the item)
  • -email is unavailable- added by banality (Submitted the item)
  • -email is unavailable- added by banality
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-10-28 craigab69 Attached File- => Added complete.patch, #47759
    2019-08-05 banality Carbon-Copy- => Added banality.time@gmail.com

    Back to the top


    Powered by Savane 3.5