bugGNU nano - Bugs: bug #55680, in current git, spotlighted text...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #55680: in current git, spotlighted text ends one column too early

Submitter:  David Lawrence Ramsey <dolorous>
Submitted:  Fri 08 Feb 2019 06:05:18 PM UTC
   
 
Severity:  5 - Blocker Status:  Fixed
Assigned to:  dolorous Open/Closed:  Closed

Thu 28 Feb 2019 06:55:04 PM UTC, comment #5: 

Fixed in a better way by commit f13dd140.  Patch by David.

Benno Schulenberg <bens>
Group administrator
Tue 12 Feb 2019 02:12:10 PM UTC, comment #4: 

Thanks for testing.  Pushed to master, commit 14f32577.

And closing, because unreleased.

Benno Schulenberg <bens>
Group administrator
Mon 11 Feb 2019 11:15:24 PM UTC, comment #3: 

After some quick testing, this seems to fix it for me too.

David Lawrence Ramsey <dolorous>
Group Member
Sat 09 Feb 2019 09:58:50 AM UTC, comment #2: 

Attached is a patch that fixes it for me.

(file #46219)

Benno Schulenberg <bens>
Group administrator
Fri 08 Feb 2019 06:10:14 PM UTC, comment #1: 

(To get a clickable link: it was the fix for bug #55620 in commit 56181896 that caused this regression.)

Benno Schulenberg <bens>
Group administrator
Fri 08 Feb 2019 06:05:18 PM UTC, original submission:  

In current git (5618189), the fix for big #55620 has introduced a problem with spotlighting text.

Specifically, the intended check for being at the prompt is overly broad.  It checks if the current menu is not the main one, but this is the case both when the user is at the prompt, and when the user is doing a search-and-replace and spotlighting text (since the current menu is the search-and-replace one then).

The latter case leads to spotlighted text's being one column short, since the logic intended for the prompt reserves one column's worth of space at the end when this is not necessary.

This can be reproduced as follows:

1. Run: ./nano -I ../README

2. Type ^W^R to enter the "Replace" prompt.

3. Type "nano" for the text to be replaced, and press Enter.

4. Type "xyzzy" for the text to use as a replacement, and press Enter.

The instances of "nano" that are found will only have "nan" highlighted.

David Lawrence Ramsey <dolorous>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Posted a comment)
  • -email is unavailable- added by dolorous (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-02-28 bens Assigned tobens dolorous
    2019-02-12 bens StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2019-02-09 bens Attached File- Added 0001-display-ensure-that-spotlighted-text-is-not-treated-.patch, #46219
        StatusNone In Progress
        Assigned toNone bens
        Summaryin current git, spotlighted text incorrectly ends one column too early in current git, spotlighted text ends one column too early
    2019-02-08 bens Severity3 - Normal 5 - Blocker

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code