GNU nano - Bugs: bug #55315, [Request] display a guiding margin...
You are not allowed to post comments on this tracker with your current authentication level.
bug #55315: [Request] display a guiding margin line on the right
Submitter: | Bryan Christ <tragicwarrior> | ||
Submitted: | Fri 28 Dec 2018 06:21:33 PM UTC | ||
Severity: | 1 - Wish | Status: | Fixed |
Assigned to: | bens | Open/Closed: | Closed |
Jump to the original submission
Mon 25 Mar 2019 01:31:28 PM UTC, comment #25: |
Benno Schulenberg <bens> |
Sat 09 Mar 2019 08:39:45 AM UTC, comment #24: The option was renamed to --guidestripe, to more clearly express what it is meant to do. And the default color is always reverse video, also when --bold is used, to avoid having an invisible stripe.
|
Benno Schulenberg <bens> |
Sun 03 Mar 2019 02:03:31 PM UTC, comment #23: Attached is a proposed patch set, that will be applied to master if no further issues arise. See also http://lists.gnu.org/archive/html/nano-devel/2019-03/msg00001.html. |
Benno Schulenberg <bens> |
Wed 20 Feb 2019 04:30:50 PM UTC, comment #22: Hmm. I was under the impression that I had already sent this patch to the devel list, to draw comments. But apparently this isn't the case. :| Have done so just now.
|
Benno Schulenberg <bens> |
Wed 20 Feb 2019 01:45:49 PM UTC, comment #21: Any chance this will go into master soon? |
Bryan Christ <tragicwarrior> |
Sat 19 Jan 2019 02:03:58 PM UTC, comment #20: Sorry. I don't use patch very often. Must have overlooked that. All is working correctly now with argv params and the entry in nanorc. Also tested with line numbering on and off. Looks good! |
Bryan Christ <tragicwarrior> |
Sat 19 Jan 2019 10:23:38 AM UTC, comment #19: Hm. Forgot to attach the patch. Now then. |
Benno Schulenberg <bens> |
Sat 19 Jan 2019 09:37:36 AM UTC, comment #18: Oh. The patch is against git, and you are patching 3.2. You missed the message that the first hunk for src/rcfile.c FAILED.
|
Benno Schulenberg <bens> |
Fri 18 Jan 2019 08:24:26 PM UTC, comment #17: Using 'set edgecolumn 80' in the rc file does not work. If I invoke with -e 80 or --edgecolumn 80 it works. Leaving the 'set edgecolumn 80" in my rc file cause nano to display an error message every time it starts saying:
|
Bryan Christ <tragicwarrior> |
Fri 18 Jan 2019 05:19:56 PM UTC, comment #16: Okay. I will test all permutations of invoking this respond in the next day or so.
|
Bryan Christ <tragicwarrior> |
Wed 16 Jan 2019 05:14:00 PM UTC, comment #15: Well, I'm waiting for confirmation that 'set edgecolumn 80' does work. Yes, it will be shown red, because the nanorc syntax hasn't been adapted yet, but that doesn't mean that it doesn't work. It should work. When not, are you spelling it right? If -e80 and --edge=80 work, then 'set edgecolumn 80' should work too. Try with a different number too, to make sure.
|
Benno Schulenberg <bens> |
Fri 11 Jan 2019 08:14:30 PM UTC, comment #14: Anything new on this? |
Bryan Christ <tragicwarrior> |
Wed 02 Jan 2019 07:45:47 PM UTC, comment #13: Also, I should have mentioned in the prev comment that --edge 80 does work now. |
Bryan Christ <tragicwarrior> |
Wed 02 Jan 2019 07:12:11 PM UTC, comment #12: I noticed that too. The motivation for this request was to make sure no lines of code exceed the 80 column boundary. So I've been running the hacked version and fixed those lines so I don't really see the mutilated characters. I think the solution would be simple though. Just add a conditional so that if the text of the line is > edgecolumn then don'te enable A_ALTCHARSET use a space instead of a 'x" as your edge_char knowing that the text will "write across".
|
Bryan Christ <tragicwarrior> |
Wed 02 Jan 2019 06:30:37 PM UTC, comment #11: Using "x" and A_ALTCHARSET looks good in an empty buffer. But try 'src/nano --edge=65 NEWS' -- it looks horrible: several letters get changed to line-drawing characters. In other words: the text gets mutilated. That's why I chose to use a background color: it doesn't interfere with the text.
|
Benno Schulenberg <bens> |
Tue 01 Jan 2019 09:22:57 PM UTC, comment #10: Also, I tested the latest patch by setting the following in nanorc and it did not have the expected effect... i still had to use -e80
|
Bryan Christ <tragicwarrior> |
Tue 01 Jan 2019 09:09:09 PM UTC, comment #9: I took a real quick stab at it and this worked (minus the coloring because I'd had to code more to find a suitable color pair.
|
Bryan Christ <tragicwarrior> |
Tue 01 Jan 2019 04:44:44 PM UTC, comment #8: 1. I'm coding a bit blind here in the example below, but take a look a man waddch and you should info on ACS_VLINE.
|
Bryan Christ <tragicwarrior> |
Tue 01 Jan 2019 03:56:12 PM UTC, comment #7: Attached is a version of the patch with a working --edge option, plus a "set edgecolumn" nanorc option, plus removal of a debugging leftover, plus it fixes an off-by-one error: humans (and nano) call the leftmost column 1, not 0.
|
Benno Schulenberg <bens> |
Tue 01 Jan 2019 03:37:01 PM UTC, comment #6: Okay. Using -eXX worked. Excellent! I turned on line numbering as well just to make sure that didn't eat into the usable space. Well done!
|
Bryan Christ <tragicwarrior> |
Tue 01 Jan 2019 09:42:34 AM UTC, comment #5: Ah, sorry. Please use the short form for testing: -e80 or -e64 or something. |
Benno Schulenberg <bens> |
Tue 01 Jan 2019 12:47:06 AM UTC, comment #4: Doesn't seem to work. Patch went okay, but invoking with the --edge argument doesn't seem to work.
|
Bryan Christ <tragicwarrior> |
Mon 31 Dec 2018 05:22:48 PM UTC, comment #3: Please try the attached patch.
|
Benno Schulenberg <bens> |
Fri 28 Dec 2018 08:11:32 PM UTC, comment #2: That all sounds good. Just having a right hand margin of any kind would be a huge help. |
Bryan Christ <tragicwarrior> |
Fri 28 Dec 2018 07:09:32 PM UTC, comment #1: The same request was made two weeks ago by a Debian user: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916392
|
Benno Schulenberg <bens> |
Fri 28 Dec 2018 06:21:33 PM UTC, original submission:
Allow the user to set a margin (max column) in the config file and display a vertical line at the specified column + 1. Also, add an additional option, something like "set marginwrap", so that when wrapping is on, it can behave at either the screen edge (if marginwrap not set) or the margin edge (marginwrap is set). |
Bryan Christ <tragicwarrior> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 15 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2019-03-25 | bens | Open/Closed | Open | Closed | |
2019-03-09 | bens | Status | In Progress | Fixed | |
2019-03-03 | bens | Attached File | - | Added 0001-new-feature-option-marginstripe-that-shows-a-vertica.patch, #46396 | |
Attached File | - | Added 0002-rcfile-add-stripecolor-for-changing-the-color-of-the.patch, #46397 | |||
Attached File | - | Added 0003-docs-describe-the-new-options-J-marginstripe-and-set.patch, #46398 | |||
Attached File | - | Added 0004-syntax-nanorc-stop-coloring-unset-fill-.-as-if-it-we.patch, #46399 | |||
2019-02-20 | bens | Attached File | - | Added 0001-new-feature-option-edgecolumn-that-shows-a-vertical-.patch, #46315 | |
2019-01-19 | bens | Attached File | - | Added backported-edgecolumn.patch, #46028 | |
2019-01-01 | bens | Attached File | - | Added 0001-possible-new-feature-add-option-edgecolumn-that-show.patch, #45827 | |
2018-12-31 | bens | Attached File | - | Added 0001-new-feature-add-option-edgecolumn-that-shows-a-verti.patch, #45817 | |
Status | None | In Progress | |||
2018-12-30 | bens | Assigned to | None | bens | |
2018-12-28 | bens | Severity | 3 - Normal | 1 - Wish | |
Summary | [Request] Display a margin | [Request] display a guiding margin line on the right | |||
2018-12-28 | tragicwarrior | Carbon-Copy | - | Added -email is unavailable- |
Powered by Savane 3.13-cf05.
Corresponding source code
The --guidestripe option has been released in version 4.0. Thanks for the request.