GNU nano - Bugs: bug #55305, undoing a multi-line cut can leave...
You are not allowed to post comments on this tracker with your current authentication level.
bug #55305: undoing a multi-line cut can leave an extra newline at EOF
Submitter: | Benno Schulenberg <bens> | ||
Submitted: | Thu 27 Dec 2018 07:41:27 PM UTC | ||
Severity: | 3 - Normal | Status: | Fixed |
Assigned to: | dolorous | Open/Closed: | Closed |
Sun 30 Dec 2018 10:42:02 AM UTC, comment #3: |
Benno Schulenberg <bens> |
Thu 27 Dec 2018 10:33:15 PM UTC, comment #2: The attached two-patch set, against git b1b2369, should fix this. It's in two steps, since one major design flaw needs to be fixed first. Specifically, all the undo code checks for xflags values via assignments, but the way the xflags values are defined, they're supposed to be bitwise values; they should be handled the same way nano's global flags are.
|
David Lawrence Ramsey <dolorous> |
Thu 27 Dec 2018 09:20:41 PM UTC, comment #1: It doesn't only occur with cut-to-eof; the same thing happens with marked cutting. To borrow from your example, run:
|
David Lawrence Ramsey <dolorous> |
Thu 27 Dec 2018 07:41:27 PM UTC, original submission:
To reproduce, run:
|
Benno Schulenberg <bens> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2019-03-25 | bens | Open/Closed | Open | Closed | |
2018-12-30 | bens | Status | None | Fixed | |
Assigned to | None | dolorous | |||
2018-12-27 | dolorous | Attached File | - | Added 0001-undo-check-xflags-in-a-bitwise-manner.patch, #45754 | |
Attached File | - | Added 0002-undo-when-undoing-a-cut-don-t-add-an-extra-magicline.patch, #45755 | |||
2018-12-27 | dolorous | Summary | undoing an M-T can leave an extra newline at EOF | undoing a multi-line cut can leave an extra newline at EOF |
Powered by Savane 3.13-f8d8.
Corresponding source code
Thanks for fixing this. Both patches applied and pushed to master. The fixing commit is 7e152f2a.