bugGNU nano - Bugs: bug #55207, the fixbounds() function appears...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #55207: the fixbounds() function appears to be superfluous

Submitted by:  Benno Schulenberg <bens>
Submitted on:  Tue 11 Dec 2018 06:46:53 PM UTC  
 
Severity:  2 - Minor Status:  Fixed
Assigned to:  Benno Schulenberg <bens> Open/Closed:  Closed

Mon 25 Mar 2019 01:28:21 PM UTC, comment #4: 

Released in 4.0.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Mon 31 Dec 2018 12:53:47 PM UTC, comment #3: 

The function was removed from master, commit 798695ff.

If this change breaks regexes containing \< or \> on your system, please report this as a new bug: https://savannah.gnu.org/bugs/?func=additem&group=nano

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Mon 31 Dec 2018 12:49:04 PM UTC, comment #2: 

Doing an 'objdump -t src/nano | grep rpl_reg' on FreeBSD, NetBSD, OpenBSD and Alpine, gives the attached results.  It appears that they all systems use the replacement regex functions from gnulib.  Those tested virtual machines all run a fairly recent system, so older systems will surely also use the gnulib regex module.  It's only newer systems that could pass all the tests that the gnulib autoconf script performs and then skip inclusion of that module.  I don't know if that autoconf script also checks for the \< and \> word boundaries -- if it doesn't, we could have a problem in the future, but we'll deal with that when and if it arrives.

(file #45810, file #45811, file #45812, file #45813)

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Tue 11 Dec 2018 06:51:35 PM UTC, comment #1: 

Also, testing a "^W M-R \<win" works as expected on all of those platforms: it finds words that start with "win" but not any "win" within words.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Tue 11 Dec 2018 06:46:53 PM UTC, original submission:  

Putting in a die() after the first few lines of the fixbounds() function in src/utils.c, I cannot get nano to die (and all tested nanos do include all syntax files), not on FreeBSD, not on OpenBSD, not on NetBSD, not on Ubuntu, and not on Alpine.  It seems that either all those systems understand GNU-style word bounds (\< and \>) nowadays, or the condigure script detects that the system's regex functions are deficient and pulls in the regex module from gnulib.  I don't know how to check for the latter, but once I find out, I will check all the BSDs and Alpine to see what they do.  If any of them already pulls in gnulib's regex module, we're fine, we can simply delete fixbounds(); otherwise we can still delete fixbounds() but then we'll maybe get a bug report somewhere down the line and then we'll have to figure out how to make nano pull in the gnulib module in that case.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.

 

Attached Files
file #45810:  fbsd-rgx-syms added by bens (293B - application/octet-stream)
file #45811:  obsd-rgx-syms added by bens (241B - application/octet-stream)
file #45812:  nbsd-rgx-syms added by bens (293B - application/octet-stream)
file #45813:  alpine-rgx-syms added by bens (241B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-25 bens Open/ClosedOpen => Closed
    2018-12-31 bens StatusIn Progress => Fixed
    2018-12-31 bens Attached File- => Added fbsd-rgx-syms, #45810
        Attached File- => Added obsd-rgx-syms, #45811
        Attached File- => Added nbsd-rgx-syms, #45812
        Attached File- => Added alpine-rgx-syms, #45813
        StatusNone => In Progress
    2018-12-11 bens Summarythe fixbouds() function appears to be superfluous => the fixbounds() function appears to be superfluous

    Back to the top


    Powered by Savane 3.5