GNU nano - Bugs: bug #54861, resizing a window doesn't adjust...
You are not allowed to post comments on this tracker with your current authentication level.
bug #54861: resizing a window doesn't adjust for a relative fill width
Submitter: | David Lawrence Ramsey <dolorous> | ||
Submitted: | Wed 17 Oct 2018 11:15:58 PM UTC | ||
Severity: | 2 - Minor | Status: | Fixed |
Assigned to: | dolorous | Open/Closed: | Closed |
Jump to the original submission
Tue 23 Oct 2018 08:01:12 PM UTC, comment #15: |
David Lawrence Ramsey <dolorous> |
Tue 23 Oct 2018 04:04:55 PM UTC, comment #14: No problem.
|
David Lawrence Ramsey <dolorous> |
Tue 23 Oct 2018 02:42:11 PM UTC, comment #13: Sorry, yes, I regretted having asked for confirmation, because after an hour I decided I wanted to apply and push out some other patches but wanted to keep the corrective patch right after your commit, the commit to be corrected. So I applied it, also because I figured that it restored the code to what is had been for a long time, and no one ever complained that --fill didn't override 'set fill', so probably the code was correct. (And I did a quick test, of course, but that has limited value.)
|
Benno Schulenberg <bens> |
Mon 22 Oct 2018 11:04:22 PM UTC, comment #12: Just in case, I've attached an updated version of the patch to swap the names of wrap_at and fill. It's now against git 71de0b9. |
David Lawrence Ramsey <dolorous> |
Mon 22 Oct 2018 06:43:16 PM UTC, comment #11: I appreciate that it's in, but if you're going to wait for a confirmation, could you wait for more than only a few hours? I wasn't in front of my development machine until just a little while ago.
|
David Lawrence Ramsey <dolorous> |
Sun 21 Oct 2018 03:27:23 PM UTC, comment #10: I didn't wait for your confirmation but have pushed the change: commit 5c5806bb. Thanks for reporting. |
Benno Schulenberg <bens> |
Sun 21 Oct 2018 10:11:41 AM UTC, comment #9: Ooof... I had compared your patch with the offending commit twice, and twice failed to notice the difference, even though I felt your patch was shorter. :| But in fact it lacked the reversal of:
|
Benno Schulenberg <bens> |
Thu 18 Oct 2018 09:41:00 PM UTC, comment #8: Patch 0002 in the previous set had an accidentally-added cosmetic rewrapping. The attached version fixes this. |
David Lawrence Ramsey <dolorous> |
Thu 18 Oct 2018 09:20:22 PM UTC, comment #7: Argh. Forget the previous patch set; it didn't set the proper values at a few points in the first patch, and it didn't account for renaming fill in text.c in the second patch.
|
David Lawrence Ramsey <dolorous> |
Thu 18 Oct 2018 07:46:14 PM UTC, comment #6: No problem. But it turns out that there's now a worse problem caused by the change, that I missed: -r on the command line no longer overrides fill in the nanorc file. (I use "fill -1" in my nanorc, and "-r 72" on the command line in some cases.)
|
David Lawrence Ramsey <dolorous> |
Thu 18 Oct 2018 06:52:04 PM UTC, comment #5: Thanks. And thanks for the improved comments.
|
Benno Schulenberg <bens> |
Thu 18 Oct 2018 01:26:34 AM UTC, comment #4: Thanks for the info.
|
David Lawrence Ramsey <dolorous> |
Wed 17 Oct 2018 11:54:35 PM UTC, comment #3: The patch fixes the issue, but "weapping" in commit message needs to be corrected. |
Brand Huntsman <brand> |
Wed 17 Oct 2018 11:22:15 PM UTC, comment #2: Also, the patch should be tagged as "reported by Brand Huntsman", but I'm not certain how to do it. |
David Lawrence Ramsey <dolorous> |
Wed 17 Oct 2018 11:21:01 PM UTC, comment #1: The problem was introduced by commit e90b7cf. The wrap_at variable was actually necessary to preserve relative values of fill, but it was removed.
|
David Lawrence Ramsey <dolorous> |
Wed 17 Oct 2018 11:15:58 PM UTC, original submission:
Taken from Brand Huntsman's report at:
|
David Lawrence Ramsey <dolorous> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 14 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-11-12 | bens | Open/Closed | Open | Closed | |
2018-10-22 | dolorous | Attached File | - | Added 0001-tweaks-swap-the-names-of-wrap_at-and-fill.patch, #45261 | |
2018-10-21 | bens | Attached File | - | Added complete-the-revert.patch, #45253 | |
2018-10-18 | dolorous | Attached File | - | Added nano-wrap.zip, #45240 | |
2018-10-18 | dolorous | Attached File | - | Added nano-wrap.zip, #45239 | |
2018-10-18 | dolorous | Attached File | - | Added 0001-wrapping-properly-set-the-wrapping-point-on-the-comm.patch, #45237 | |
Attached File | - | Added 0002-tweaks-swap-the-names-of-wrap_at-and-fill.patch, #45238 | |||
2018-10-18 | bens | Severity | 3 - Normal | 2 - Minor | |
Status | None | Fixed | |||
Assigned to | None | dolorous | |||
Summary | resizing a window to a larger width doesn't change relative width when it should | resizing a window doesn't adjust for a relative fill width | |||
2018-10-18 | dolorous | Attached File | - | Added 0001-wrapping-make-relative-fill-sizes-work-properly-agai.patch, #45231 | |
2018-10-17 | dolorous | Attached File | - | Added 0001-weapping-make-relative-fill-sizes-work-properly-agai.patch, #45230 | |
Carbon-Copy | - | Added bens |
Powered by Savane 3.13-02a9.
Corresponding source code
Typo: make that "I figured it wouldn't be getting in 3.2".