bugGNU nano - Bugs: bug #54824, when using --view --multi...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #54824: when using --view --multi --restrict, ^R gives wrong message

Submitted by:  Benno Schulenberg <bens>
Submitted on:  Fri 12 Oct 2018 09:20:49 AM UTC  
 
Severity:  2 - Minor Status:  Fixed
Assigned to:  Benno Schulenberg <bens> Open/Closed:  Closed

Fri 12 Oct 2018 10:16:48 AM UTC, comment #2: 

Fixed in git, commit 6b086483.

In addition, this change is a better fix for bug #54650, so the change of commit fe3a72ce has become superfluous.

Furthermore, this change prevents the multiline regexes being checked when a feature is toggled -- something that will never affect those regexes.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Fri 12 Oct 2018 09:47:26 AM UTC, comment #1: 

It wasn't easy to determine the offending commit.  Commit 54103d8e caused a segfault.  Only when considering this segfault to be "good", does bisecting bring us to commit 8b8c6bb8 as the culprit.

This commit changes the logic.  Before, the view warning would be printed only when a function could be found AND viewok was true.  After, the warning will also be printed when a function could not be found.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Fri 12 Oct 2018 09:20:49 AM UTC, original submission:  

To reproduce, run:

  src/nano --ignore --view --multibuffer --restricted NEWS

Then type: ^R.  The status bar says: "[ Key is invalid in view mode ]".  But this is incorrect, because when --view and --multibuffer are combined, reading a file into a new buffer is allowed.  It is the --restricted that disallows ^R in this case.  So that is what the status bar should say.

Bug exists since nano-2.9.5.  Version 2.9.3 still gave the correct message.  Version 2.9.4 segfaults when trying to read a file in restricted mode.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-11-12 bens Open/ClosedOpen => Closed
    2018-10-12 bens StatusIn Progress => Fixed
    2018-10-12 bens StatusNone => In Progress

    Back to the top


    Powered by Savane 3.5