GNU nano - Bugs: bug #54573, full-justify can go into an...
You are not allowed to post comments on this tracker with your current authentication level.
bug #54573: full-justify can go into an infinite loop when the last line isn't a paragraph
Submitter: | David Lawrence Ramsey <dolorous> | ||
Submitted: | Sun 26 Aug 2018 04:07:56 PM UTC | ||
Severity: | 4 - Important | Status: | Fixed |
Assigned to: | dolorous | Open/Closed: | Closed |
Jump to the original submission
Mon 10 Sep 2018 05:52:21 PM UTC, comment #9: |
Benno Schulenberg <bens> |
Mon 27 Aug 2018 06:31:12 PM UTC, comment #8: Thanks for the patch. Applied, with a tweaked commit message, and pushed, commit 93c8e316. |
Benno Schulenberg <bens> |
Sun 26 Aug 2018 11:22:58 PM UTC, comment #7: Attached a new version of the patch, unchanged except for an improved commit message (which also references the bug number, as it should have before). Sorry for the mess. |
David Lawrence Ramsey <dolorous> |
Sun 26 Aug 2018 06:21:18 PM UTC, comment #6: And, to be clear, it fixes the incorrect behavior with justify as well as the hang with full-justify. |
David Lawrence Ramsey <dolorous> |
Sun 26 Aug 2018 06:12:08 PM UTC, comment #5: The fix turned out to be easier than I thought, and works with your new example as well. Attached. |
David Lawrence Ramsey <dolorous> |
Sun 26 Aug 2018 05:38:48 PM UTC, comment #4: Wow, a hang! Superb find! :)
|
Benno Schulenberg <bens> |
Sun 26 Aug 2018 05:29:54 PM UTC, comment #3: The underlying problems are caused by the paragraph detection. This can be demonstrated as follows:
|
David Lawrence Ramsey <dolorous> |
Sun 26 Aug 2018 05:15:01 PM UTC, comment #2: Addendum:, the bug manifests differently (not an infinite loop, but still incorrect behavior) when manually justifying the entire file, step by step. Specifically:
|
David Lawrence Ramsey <dolorous> |
Sun 26 Aug 2018 04:58:25 PM UTC, comment #1: Argh; attached proper version of justify-bug.txt. |
David Lawrence Ramsey <dolorous> |
Sun 26 Aug 2018 04:07:56 PM UTC, original submission:
This occurs with current git (80bea3e), 2.9.8, and 2.9.7 so far. I haven't had time yet to check how far back it goes, but the last major changes to the justify code were the recursion changes after 2.9.7, so those apparently aren't the cause.
|
David Lawrence Ramsey <dolorous> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 10 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-09-10 | bens | Open/Closed | Open | Closed | |
2018-08-27 | bens | Status | None | Fixed | |
Assigned to | None | dolorous | |||
2018-08-26 | dolorous | Attached File | - | Added 0001-justify-add-another-check-for-being-in-a-paragraph-t.patch, #44871 | |
2018-08-26 | dolorous | Attached File | - | Added 0001-justify-add-another-check-for-being-in-a-paragraph-t.patch, #44870 | |
2018-08-26 | bens | Severity | 3 - Normal | 4 - Important | |
2018-08-26 | dolorous | Attached File | - | Added justify-bug2.txt, #44868 | |
2018-08-26 | dolorous | Attached File | #44866 | Removed | |
2018-08-26 | dolorous | Attached File | - | Added justify-bug.txt, #44867 | |
2018-08-26 | dolorous | Attached File | - | Added justify-bug.txt, #44866 |
Powered by Savane 3.13-f8d8.
Corresponding source code
Released in 3.0.